Closed
Conversation
gretay-js
requested review from
Gbury,
chambart,
lthls,
lukemaurer,
mshinwell,
poechsel,
stedolan and
xclerc
as code owners
Closed
Contributor
Author
|
This is now failing because ocamlformat.yml github workflow we have doesn't set up special dune when doing configure. Why do we have it in a separate workflow file? |
gretay-js
force-pushed
the
unify-ocamlformat-files
branch
from
91dbd03 to
428a910
Compare
Collaborator
|
@gretay-js not sure there is any particularly good reason it's in a separate file |
Contributor
Author
ok, maybe I can add it as an extra target in one of the existing builds. |
Contributor
|
@gretay-js we can probably close this one I think ? |
Collaborator
|
@gretay-js ping |
Contributor
Author
|
I'll rebase and fix it up. |
Contributor
|
Ping again on that one ? |
Contributor
Author
|
out of date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
make fmtto usedune build @fmt --auto-promote.I'm slightly worried about other consequences of vendoring
ocaml: targets that aren't explicitly requested by toplevel dune file won't build or install any more, according to the dune docs), but nothing is missing from the install directory.