Improved simplification of array operations by mshinwell · Pull Request #384 · oxcaml/oxcaml

mshinwell · 2021-11-15T09:58:55Z

This pull request should significantly improve the performance of generated code involving arrays. At present some of the code generation is poor (see the levinson-durbin benchmark for example). This especially happens when functions involving arrays (often generic or, without the float array optimisation enabled, "addr" arrays) are inlined into other functions.

So there are two general aims:

Eliminate as many tag tests arising from the float array optimisation as possible.
Reduce calls to caml_modify when writing to arrays of immediates.

The approach is as follows. Everything to do with arrays is rather subtle, so I've probably made some mistakes here.

Add a new Lambda value kind for arrays. Luckily there was already a function in the type checker for working out the element type of an array, given the array's type.
Add a new primitive Is_boxed_float which tests if a value has the tag of a boxed float (Double_tag).
Add a new primitive Is_flat_float_array which tests if a value has the tag of an unboxed float array (Double_array_tag).
Pull the tag tests for the float array optimisation back from the generated Cmm code into the generated Flambda 2 code itself. The generated code uses the two new primitives above.
Remove the Float_array_opt_dynamic constructors from Flambda_primitive, which simplifies the definition of types such as Array_kind.
Remember the kind (with subkind) of the element type of arrays in the Flambda 2 typing.
Examine the "initial value" argument to caml_make_vect to remove float array optimisation tag tests on the results of Array.make, since in such cases the Lambda value kind doesn't help us. (This rule is unfortunately only relevant to float array optimisation tag tests rather than to specialisation to immediate array operations, since we can only deduce kind rather than subkind information by looking at the initial value.) One deficiency with this part is that we don't update the value kind on the parameter of the corresponding Apply node's return continuation.
Add simplification rules for the two new primitives and add proper simplification rules for the existing Array_load and Array_set primitives.
Allow specialisation of array primitives in the case where the array is known (from the subkind information) to only hold immediates but the primitives are still saying "arrays of any value" (or, when the float array optimisation is enabled, "arrays of any non-float value"). This is the part that reduces caml_modify calls.

The removal of the float array optimisation tag tests happens automatically as part of simplification (by virtue of the rules for Is_boxed_float and Is_flat_float_array) and requires no further logic.

Here are some examples:

let[@inline always] array_op a x = a.(x)

let f a p q =
  array_op a p + array_op a q

This is a typical example where, at present, the function being inlined must be monomorphised (e.g. by annotating "x : int array") to avoid the float array optimisation tag tests. With this PR such annotations are no longer required.

Even with the float array optimisation disabled, the analogous example with an array set is also improved:

let[@inline always] array_op a x n = a.(x) <- n

let f a p q =
  array_op a p q;
  array_op a q p

With the existing compiler, there are not only the float array optimisation tag tests, but also calls to caml_modify within f. With this PR there are simply two writes of immediates.

Finally here is an example of code using Array.make which, when the float array optimisation is enabled, is improved by this PR: all tag tests are removed. (The "+ 0." at the end shows why we need something like partial dead code elimination to push the final float boxing out of the loop.)

let[@inline always] get a i = a.(i)

let f init len =
  let r = ref 0. in
  let arr = Array.make len init in
  for i = 0 to len - 1 do
    r := !r +. get arr i
  done;
  !r +. 0.

mshinwell · 2021-11-15T10:29:52Z

I forgot one thing: the Array_length primitive doesn't take an array kind argument any more, to be certain that tag tests are avoided. These are unnecessary on 64-bit targets. We already don't support 32-bit targets and it seems unlikely to me that will change in the future. If it does, it isn't a huge problem.

xclerc

(Only for the Cmmgen module.)

mshinwell · 2021-11-15T10:43:49Z

I forgot one thing: the Array_length primitive doesn't take an array kind argument any more, to be certain that tag tests are avoided. These are unnecessary on 64-bit targets. We already don't support 32-bit targets and it seems unlikely to me that will change in the future. If it does, it isn't a huge problem.

In fact this PR could be changed so the new check about the word/float sizes only triggers if the float array optimisation is enabled. I think if that's disabled we're ok even on 32 bit platforms.

middle_end/flambda2/to_cmm/to_cmm.ml

middle_end/flambda2/flambda2.ml

middle_end/flambda2/from_lambda/lambda_to_flambda_primitives.ml

middle_end/flambda2/simplify/simplify_apply_expr.ml

middle_end/flambda2/simplify/simplify_extcall.ml

middle_end/flambda2/simplify/simplify_unary_primitive.ml

middle_end/flambda2/terms/flambda_primitive.ml

middle_end/flambda2/types/grammar/type_grammar.ml

middle_end/flambda2/to_cmm/to_cmm.ml

middle_end/flambda2/to_cmm/to_cmm_static.ml

Co-authored-by: Guillaume Bury <[email protected]>

mshinwell · 2021-12-03T14:17:34Z

I have cherry-picked the commits from mshinwell#8

gretay-js

Approving only for cmmgen. I don't entirely understand the new Parrayval but the changes seems safe as it is treated "strictly".

ocaml/lambda/printlambda.ml

lthls

The changes related to the new Parrayval value kind look sensible.

@inline

23a7f73 flambda-backend: Fix some Debuginfo.t scopes in the frontend (oxcaml#248) 33a04a6 flambda-backend: Attempt to shrink the heap before calling the assembler (oxcaml#429) 8a36a16 flambda-backend: Fix to allow stage 2 builds in Flambda 2 -Oclassic mode (oxcaml#442) d828db6 flambda-backend: Rename -no-extensions flag to -disable-all-extensions (oxcaml#425) 68c39d5 flambda-backend: Fix mistake with extension records (oxcaml#423) 423f312 flambda-backend: Refactor -extension and -standard flags (oxcaml#398) 585e023 flambda-backend: Improved simplification of array operations (oxcaml#384) faec6b1 flambda-backend: Typos (oxcaml#407) 8914940 flambda-backend: Ensure allocations are initialised, even dead ones (oxcaml#405) 6b58001 flambda-backend: Move compiler flag -dcfg out of ocaml/ subdirectory (oxcaml#400) 4fd57cf flambda-backend: Use ghost loc for extension to avoid expressions with overlapping locations (oxcaml#399) 8d993c5 flambda-backend: Let's fix instead of reverting flambda_backend_args (oxcaml#396) d29b133 flambda-backend: Revert "Move flambda-backend specific flags out of ocaml/ subdirectory (oxcaml#382)" (oxcaml#395) d0cda93 flambda-backend: Revert oxcaml#373 (oxcaml#393) 1c6eee1 flambda-backend: Fix "make check_all_arches" in ocaml/ subdirectory (oxcaml#388) a7960dd flambda-backend: Move flambda-backend specific flags out of ocaml/ subdirectory (oxcaml#382) bf7b1a8 flambda-backend: List and Array Comprehensions (oxcaml#147) f2547de flambda-backend: Compile more stdlib files with -O3 (oxcaml#380) 3620c58 flambda-backend: Four small inliner fixes (oxcaml#379) 2d165d2 flambda-backend: Regenerate ocaml/configure 3838b56 flambda-backend: Bump Menhir to version 20210419 (oxcaml#362) 43c14d6 flambda-backend: Re-enable -flambda2-join-points (oxcaml#374) 5cd2520 flambda-backend: Disable inlining of recursive functions by default (oxcaml#372) e98b277 flambda-backend: Import #10736 (stack limit increases) (oxcaml#373) 82c8086 flambda-backend: Use hooks for type tree and parse tree (oxcaml#363) 33bbc93 flambda-backend: Fix parsecmm.mly in ocaml subdirectory (oxcaml#357) 9650034 flambda-backend: Right-to-left evaluation of arguments of String.get and friends (oxcaml#354) f7d3775 flambda-backend: Revert "Magic numbers" (oxcaml#360) 0bd2fa6 flambda-backend: Add [@inline ready] attribute and remove [@inline hint] (not [@inlined hint]) (oxcaml#351) cee74af flambda-backend: Ensure that functions are evaluated after their arguments (oxcaml#353) 954be59 flambda-backend: Bootstrap dd5c299 flambda-backend: Change prefix of all magic numbers to avoid clashes with upstream. c2b1355 flambda-backend: Fix wrong shift generation in Cmm_helpers (oxcaml#347) 739243b flambda-backend: Add flambda_oclassic attribute (oxcaml#348) dc9b7fd flambda-backend: Only speculate during inlining if argument types have useful information (oxcaml#343) aa190ec flambda-backend: Backport fix from PR#10719 (oxcaml#342) c53a574 flambda-backend: Reduce max inlining depths at -O2 and -O3 (oxcaml#334) a2493dc flambda-backend: Tweak error messages in Compenv. 1c7b580 flambda-backend: Change Name_abstraction to use a parameterized type (oxcaml#326) 07e0918 flambda-backend: Save cfg to file (oxcaml#257) 9427a8d flambda-backend: Make inlining parameters more aggressive (oxcaml#332) fe0610f flambda-backend: Do not cache young_limit in a processor register (upstream PR 9876) (oxcaml#315) 56f28b8 flambda-backend: Fix an overflow bug in major GC work computation (oxcaml#310) 8e43a49 flambda-backend: Cmm invariants (port upstream PR 1400) (oxcaml#258) e901f16 flambda-backend: Add attributes effects and coeffects (oxcaml#18) aaa1cdb flambda-backend: Expose Flambda 2 flags via OCAMLPARAM (oxcaml#304) 62db54f flambda-backend: Fix freshening substitutions 57231d2 flambda-backend: Evaluate signature substitutions lazily (upstream PR 10599) (oxcaml#280) a1a07de flambda-backend: Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412) (oxcaml#238) faaf149 flambda-backend: Rename Un_cps -> To_cmm (oxcaml#261) ecb0201 flambda-backend: Add "-dcfg" flag to ocamlopt (oxcaml#254) 32ec58a flambda-backend: Bypass Simplify (oxcaml#162) bd4ce4a flambda-backend: Revert "Semaphore without probes: dummy notes (oxcaml#142)" (oxcaml#242) c98530f flambda-backend: Semaphore without probes: dummy notes (oxcaml#142) c9b6a04 flambda-backend: Remove hack for .depend from runtime/dune (oxcaml#170) 6e5d4cf flambda-backend: Build and install Semaphore (oxcaml#183) 924eb60 flambda-backend: Special constructor for %sys_argv primitive (oxcaml#166) 2ac6334 flambda-backend: Build ocamldoc (oxcaml#157) c6f7267 flambda-backend: Add -mbranches-within-32B to major_gc.c compilation (where supported) a99fdee flambda-backend: Merge pull request ocaml#10195 from stedolan/mark-prefetching bd72dcb flambda-backend: Prefetching optimisations for sweeping (ocaml#9934) 27fed7e flambda-backend: Add missing index param for Obj.field (oxcaml#145) cd48b2f flambda-backend: Fix camlinternalOO at -O3 with Flambda 2 (oxcaml#132) 9d85430 flambda-backend: Fix testsuite execution (oxcaml#125) ac964ca flambda-backend: Comment out `[@inlined]` annotation. (oxcaml#136) ad4afce flambda-backend: Fix magic numbers (test suite) (oxcaml#135) 9b033c7 flambda-backend: Disable the comparison of bytecode programs (`ocamltest`) (oxcaml#128) e650abd flambda-backend: Import flambda2 changes (`Asmpackager`) (oxcaml#127) 14dcc38 flambda-backend: Fix error with Record_unboxed (bug in block kind patch) (oxcaml#119) 2d35761 flambda-backend: Resurrect [@inline never] annotations in camlinternalMod (oxcaml#121) f5985ad flambda-backend: Magic numbers for cmx and cmxa files (oxcaml#118) 0e8b9f0 flambda-backend: Extend conditions to include flambda2 (oxcaml#115) 99870c8 flambda-backend: Fix Translobj assertions for Flambda 2 (oxcaml#112) 5106317 flambda-backend: Minor fix for "lazy" compilation in Matching with Flambda 2 (oxcaml#110) dba922b flambda-backend: Oclassic/O2/O3 etc (oxcaml#104) f88af3e flambda-backend: Wire in the remaining Flambda 2 flags (oxcaml#103) 678d647 flambda-backend: Wire in the Flambda 2 inlining flags (oxcaml#100) 1a8febb flambda-backend: Formatting of help text for some Flambda 2 options (oxcaml#101) 9ae1c7a flambda-backend: First set of command-line flags for Flambda 2 (oxcaml#98) bc0bc5e flambda-backend: Add config variables flambda_backend, flambda2 and probes (oxcaml#99) efb8304 flambda-backend: Build our own ocamlobjinfo from tools/objinfo/ at the root (oxcaml#95) d2cfaca flambda-backend: Add mutability annotations to Pfield etc. (oxcaml#88) 5532555 flambda-backend: Lambda block kinds (oxcaml#86) 0c597ba flambda-backend: Revert VERSION, etc. back to 4.12.0 (mostly reverts 822d0a0 from upstream 4.12) (oxcaml#93) 037c3d0 flambda-backend: Float blocks 7a9d190 flambda-backend: Allow --enable-middle-end=flambda2 etc (oxcaml#89) 9057474 flambda-backend: Root scanning fixes for Flambda 2 (oxcaml#87) 08e02a3 flambda-backend: Ensure that Lifthenelse has a boolean-valued condition (oxcaml#63) 77214b7 flambda-backend: Obj changes for Flambda 2 (oxcaml#71) ecfdd72 flambda-backend: Cherry-pick 9432cfd (oxcaml#84) d1a4396 flambda-backend: Add a `returns` field to `Cmm.Cextcall` (oxcaml#74) 575dff5 flambda-backend: CMM traps (oxcaml#72) 8a87272 flambda-backend: Remove Obj.set_tag and Obj.truncate (oxcaml#73) d9017ae flambda-backend: Merge pull request oxcaml#80 from mshinwell/fb-backport-pr10205 3a4824e flambda-backend: Backport PR#10205 from upstream: Avoid overwriting closures while initialising recursive modules f31890e flambda-backend: Install missing headers of ocaml/runtime/caml (oxcaml#77) 83516f8 flambda-backend: Apply node created for probe should not be annotated as tailcall (oxcaml#76) bc430cb flambda-backend: Add Clflags.is_flambda2 (oxcaml#62) ed87247 flambda-backend: Preallocation of blocks in Translmod for value let rec w/ flambda2 (oxcaml#59) a4b04d5 flambda-backend: inline never on Gc.create_alarm (oxcaml#56) cef0bb6 flambda-backend: Config.flambda2 (oxcaml#58) ff0e4f7 flambda-backend: Pun labelled arguments with type constraint in function applications (oxcaml#53) d72c5fb flambda-backend: Remove Cmm.memory_chunk.Double_u (oxcaml#42) 9d34d99 flambda-backend: Install missing artifacts 10146f2 flambda-backend: Add ocamlcfg (oxcaml#34) 819d38a flambda-backend: Use OC_CFLAGS, OC_CPPFLAGS, and SHAREDLIB_CFLAGS for foreign libs (oxcaml#30) f98b564 flambda-backend: Pass -function-sections iff supported. (oxcaml#29) e0eef5e flambda-backend: Bootstrap (oxcaml#11 part 2) 17374b4 flambda-backend: Add [@@Builtin] attribute to Primitives (oxcaml#11 part 1) 85127ad flambda-backend: Add builtin, effects and coeffects fields to Cextcall (oxcaml#12) b670bcf flambda-backend: Replace tuple with record in Cextcall (oxcaml#10) db451b5 flambda-backend: Speedups in Asmlink (oxcaml#8) 2fe489d flambda-backend: Cherry-pick upstream PR#10184 from upstream, dynlink invariant removal (rev 3dc3cd7 upstream) d364bfa flambda-backend: Local patch against upstream: enable function sections in the Dune build 886b800 flambda-backend: Local patch against upstream: remove Raw_spacetime_lib (does not build with -m32) 1a7db7c flambda-backend: Local patch against upstream: make dune ignore ocamldoc/ directory e411dd3 flambda-backend: Local patch against upstream: remove ocaml/testsuite/tests/tool-caml-tex/ 1016d03 flambda-backend: Local patch against upstream: remove ocaml/dune-project and ocaml/ocaml-variants.opam 93785e3 flambda-backend: To upstream: export-dynamic for otherlibs/dynlink/ via the natdynlinkops files (still needs .gitignore + way of generating these files) 63db8c1 flambda-backend: To upstream: stop using -O3 in otherlibs/Makefile.otherlibs.common eb2f1ed flambda-backend: To upstream: stop using -O3 for dynlink/ 6682f8d flambda-backend: To upstream: use flambda_o3 attribute instead of -O3 in the Makefile for systhreads/ de197df flambda-backend: To upstream: renamed ocamltest_unix.xxx files for dune bf3773d flambda-backend: To upstream: dune build fixes (depends on previous to-upstream patches) 6fbc80e flambda-backend: To upstream: refactor otherlibs/dynlink/, removing byte/ and native/ 71a03ef flambda-backend: To upstream: fix to Ocaml_modifiers in ocamltest 686d6e3 flambda-backend: To upstream: fix dependency problem with Instruct c311155 flambda-backend: To upstream: remove threadUnix 52e6e78 flambda-backend: To upstream: stabilise filenames used in backtraces: stdlib/, otherlibs/systhreads/, toplevel/toploop.ml 7d08e0e flambda-backend: To upstream: use flambda_o3 attribute in stdlib 403b82e flambda-backend: To upstream: flambda_o3 attribute support (includes bootstrap) 65032b1 flambda-backend: To upstream: use nolabels attribute instead of -nolabels for otherlibs/unix/ f533fad flambda-backend: To upstream: remove Compflags, add attributes, etc. 49fc1b5 flambda-backend: To upstream: Add attributes and bootstrap compiler a4b9e0d flambda-backend: Already upstreamed: stdlib capitalisation patch 4c1c259 flambda-backend: ocaml#9748 from xclerc/share-ev_defname (cherry-pick 3e937fcb562) 00027c4 flambda-backend: permanent/default-to-best-fit (cherry-pick 64240fd716a9d0db57d779ebe5b6f1a67704cdec) 2561dd9 flambda-backend: permanent/reraise-by-default (cherry-pick 50e94902ca6bb84c33982db858b74322eefd9af8) c0aa4f4 flambda-backend: permanent/gc-tuning (cherry-pick e9d6d2f145438dd6a82b56e9b41c8a01e752d81d) git-subtree-dir: ocaml git-subtree-split: 23a7f73

@inline

23a7f73 flambda-backend: Fix some Debuginfo.t scopes in the frontend (#248) 33a04a6 flambda-backend: Attempt to shrink the heap before calling the assembler (#429) 8a36a16 flambda-backend: Fix to allow stage 2 builds in Flambda 2 -Oclassic mode (#442) d828db6 flambda-backend: Rename -no-extensions flag to -disable-all-extensions (#425) 68c39d5 flambda-backend: Fix mistake with extension records (#423) 423f312 flambda-backend: Refactor -extension and -standard flags (#398) 585e023 flambda-backend: Improved simplification of array operations (#384) faec6b1 flambda-backend: Typos (#407) 8914940 flambda-backend: Ensure allocations are initialised, even dead ones (#405) 6b58001 flambda-backend: Move compiler flag -dcfg out of ocaml/ subdirectory (#400) 4fd57cf flambda-backend: Use ghost loc for extension to avoid expressions with overlapping locations (#399) 8d993c5 flambda-backend: Let's fix instead of reverting flambda_backend_args (#396) d29b133 flambda-backend: Revert "Move flambda-backend specific flags out of ocaml/ subdirectory (#382)" (#395) d0cda93 flambda-backend: Revert #373 (#393) 1c6eee1 flambda-backend: Fix "make check_all_arches" in ocaml/ subdirectory (#388) a7960dd flambda-backend: Move flambda-backend specific flags out of ocaml/ subdirectory (#382) bf7b1a8 flambda-backend: List and Array Comprehensions (#147) f2547de flambda-backend: Compile more stdlib files with -O3 (#380) 3620c58 flambda-backend: Four small inliner fixes (#379) 2d165d2 flambda-backend: Regenerate ocaml/configure 3838b56 flambda-backend: Bump Menhir to version 20210419 (#362) 43c14d6 flambda-backend: Re-enable -flambda2-join-points (#374) 5cd2520 flambda-backend: Disable inlining of recursive functions by default (#372) e98b277 flambda-backend: Import #10736 (stack limit increases) (#373) 82c8086 flambda-backend: Use hooks for type tree and parse tree (#363) 33bbc93 flambda-backend: Fix parsecmm.mly in ocaml subdirectory (#357) 9650034 flambda-backend: Right-to-left evaluation of arguments of String.get and friends (#354) f7d3775 flambda-backend: Revert "Magic numbers" (#360) 0bd2fa6 flambda-backend: Add [@inline ready] attribute and remove [@inline hint] (not [@inlined hint]) (#351) cee74af flambda-backend: Ensure that functions are evaluated after their arguments (#353) 954be59 flambda-backend: Bootstrap dd5c299 flambda-backend: Change prefix of all magic numbers to avoid clashes with upstream. c2b1355 flambda-backend: Fix wrong shift generation in Cmm_helpers (#347) 739243b flambda-backend: Add flambda_oclassic attribute (#348) dc9b7fd flambda-backend: Only speculate during inlining if argument types have useful information (#343) aa190ec flambda-backend: Backport fix from PR#10719 (#342) c53a574 flambda-backend: Reduce max inlining depths at -O2 and -O3 (#334) a2493dc flambda-backend: Tweak error messages in Compenv. 1c7b580 flambda-backend: Change Name_abstraction to use a parameterized type (#326) 07e0918 flambda-backend: Save cfg to file (#257) 9427a8d flambda-backend: Make inlining parameters more aggressive (#332) fe0610f flambda-backend: Do not cache young_limit in a processor register (upstream PR 9876) (#315) 56f28b8 flambda-backend: Fix an overflow bug in major GC work computation (#310) 8e43a49 flambda-backend: Cmm invariants (port upstream PR 1400) (#258) e901f16 flambda-backend: Add attributes effects and coeffects (#18) aaa1cdb flambda-backend: Expose Flambda 2 flags via OCAMLPARAM (#304) 62db54f flambda-backend: Fix freshening substitutions 57231d2 flambda-backend: Evaluate signature substitutions lazily (upstream PR 10599) (#280) a1a07de flambda-backend: Keep Sys.opaque_identity in Cmm and Mach (port upstream PR 9412) (#238) faaf149 flambda-backend: Rename Un_cps -> To_cmm (#261) ecb0201 flambda-backend: Add "-dcfg" flag to ocamlopt (#254) 32ec58a flambda-backend: Bypass Simplify (#162) bd4ce4a flambda-backend: Revert "Semaphore without probes: dummy notes (#142)" (#242) c98530f flambda-backend: Semaphore without probes: dummy notes (#142) c9b6a04 flambda-backend: Remove hack for .depend from runtime/dune (#170) 6e5d4cf flambda-backend: Build and install Semaphore (#183) 924eb60 flambda-backend: Special constructor for %sys_argv primitive (#166) 2ac6334 flambda-backend: Build ocamldoc (#157) c6f7267 flambda-backend: Add -mbranches-within-32B to major_gc.c compilation (where supported) a99fdee flambda-backend: Merge pull request ocaml#10195 from stedolan/mark-prefetching bd72dcb flambda-backend: Prefetching optimisations for sweeping (ocaml#9934) 27fed7e flambda-backend: Add missing index param for Obj.field (#145) cd48b2f flambda-backend: Fix camlinternalOO at -O3 with Flambda 2 (#132) 9d85430 flambda-backend: Fix testsuite execution (#125) ac964ca flambda-backend: Comment out `[@inlined]` annotation. (#136) ad4afce flambda-backend: Fix magic numbers (test suite) (#135) 9b033c7 flambda-backend: Disable the comparison of bytecode programs (`ocamltest`) (#128) e650abd flambda-backend: Import flambda2 changes (`Asmpackager`) (#127) 14dcc38 flambda-backend: Fix error with Record_unboxed (bug in block kind patch) (#119) 2d35761 flambda-backend: Resurrect [@inline never] annotations in camlinternalMod (#121) f5985ad flambda-backend: Magic numbers for cmx and cmxa files (#118) 0e8b9f0 flambda-backend: Extend conditions to include flambda2 (#115) 99870c8 flambda-backend: Fix Translobj assertions for Flambda 2 (#112) 5106317 flambda-backend: Minor fix for "lazy" compilation in Matching with Flambda 2 (#110) dba922b flambda-backend: Oclassic/O2/O3 etc (#104) f88af3e flambda-backend: Wire in the remaining Flambda 2 flags (#103) 678d647 flambda-backend: Wire in the Flambda 2 inlining flags (#100) 1a8febb flambda-backend: Formatting of help text for some Flambda 2 options (#101) 9ae1c7a flambda-backend: First set of command-line flags for Flambda 2 (#98) bc0bc5e flambda-backend: Add config variables flambda_backend, flambda2 and probes (#99) efb8304 flambda-backend: Build our own ocamlobjinfo from tools/objinfo/ at the root (#95) d2cfaca flambda-backend: Add mutability annotations to Pfield etc. (#88) 5532555 flambda-backend: Lambda block kinds (#86) 0c597ba flambda-backend: Revert VERSION, etc. back to 4.12.0 (mostly reverts 822d0a0 from upstream 4.12) (#93) 037c3d0 flambda-backend: Float blocks 7a9d190 flambda-backend: Allow --enable-middle-end=flambda2 etc (#89) 9057474 flambda-backend: Root scanning fixes for Flambda 2 (#87) 08e02a3 flambda-backend: Ensure that Lifthenelse has a boolean-valued condition (#63) 77214b7 flambda-backend: Obj changes for Flambda 2 (#71) ecfdd72 flambda-backend: Cherry-pick 9432cfd (#84) d1a4396 flambda-backend: Add a `returns` field to `Cmm.Cextcall` (#74) 575dff5 flambda-backend: CMM traps (#72) 8a87272 flambda-backend: Remove Obj.set_tag and Obj.truncate (#73) d9017ae flambda-backend: Merge pull request #80 from mshinwell/fb-backport-pr10205 3a4824e flambda-backend: Backport PR#10205 from upstream: Avoid overwriting closures while initialising recursive modules f31890e flambda-backend: Install missing headers of ocaml/runtime/caml (#77) 83516f8 flambda-backend: Apply node created for probe should not be annotated as tailcall (#76) bc430cb flambda-backend: Add Clflags.is_flambda2 (#62) ed87247 flambda-backend: Preallocation of blocks in Translmod for value let rec w/ flambda2 (#59) a4b04d5 flambda-backend: inline never on Gc.create_alarm (#56) cef0bb6 flambda-backend: Config.flambda2 (#58) ff0e4f7 flambda-backend: Pun labelled arguments with type constraint in function applications (#53) d72c5fb flambda-backend: Remove Cmm.memory_chunk.Double_u (#42) 9d34d99 flambda-backend: Install missing artifacts 10146f2 flambda-backend: Add ocamlcfg (#34) 819d38a flambda-backend: Use OC_CFLAGS, OC_CPPFLAGS, and SHAREDLIB_CFLAGS for foreign libs (#30) f98b564 flambda-backend: Pass -function-sections iff supported. (#29) e0eef5e flambda-backend: Bootstrap (#11 part 2) 17374b4 flambda-backend: Add [@@Builtin] attribute to Primitives (#11 part 1) 85127ad flambda-backend: Add builtin, effects and coeffects fields to Cextcall (#12) b670bcf flambda-backend: Replace tuple with record in Cextcall (#10) db451b5 flambda-backend: Speedups in Asmlink (#8) 2fe489d flambda-backend: Cherry-pick upstream PR#10184 from upstream, dynlink invariant removal (rev 3dc3cd7 upstream) d364bfa flambda-backend: Local patch against upstream: enable function sections in the Dune build 886b800 flambda-backend: Local patch against upstream: remove Raw_spacetime_lib (does not build with -m32) 1a7db7c flambda-backend: Local patch against upstream: make dune ignore ocamldoc/ directory e411dd3 flambda-backend: Local patch against upstream: remove ocaml/testsuite/tests/tool-caml-tex/ 1016d03 flambda-backend: Local patch against upstream: remove ocaml/dune-project and ocaml/ocaml-variants.opam 93785e3 flambda-backend: To upstream: export-dynamic for otherlibs/dynlink/ via the natdynlinkops files (still needs .gitignore + way of generating these files) 63db8c1 flambda-backend: To upstream: stop using -O3 in otherlibs/Makefile.otherlibs.common eb2f1ed flambda-backend: To upstream: stop using -O3 for dynlink/ 6682f8d flambda-backend: To upstream: use flambda_o3 attribute instead of -O3 in the Makefile for systhreads/ de197df flambda-backend: To upstream: renamed ocamltest_unix.xxx files for dune bf3773d flambda-backend: To upstream: dune build fixes (depends on previous to-upstream patches) 6fbc80e flambda-backend: To upstream: refactor otherlibs/dynlink/, removing byte/ and native/ 71a03ef flambda-backend: To upstream: fix to Ocaml_modifiers in ocamltest 686d6e3 flambda-backend: To upstream: fix dependency problem with Instruct c311155 flambda-backend: To upstream: remove threadUnix 52e6e78 flambda-backend: To upstream: stabilise filenames used in backtraces: stdlib/, otherlibs/systhreads/, toplevel/toploop.ml 7d08e0e flambda-backend: To upstream: use flambda_o3 attribute in stdlib 403b82e flambda-backend: To upstream: flambda_o3 attribute support (includes bootstrap) 65032b1 flambda-backend: To upstream: use nolabels attribute instead of -nolabels for otherlibs/unix/ f533fad flambda-backend: To upstream: remove Compflags, add attributes, etc. 49fc1b5 flambda-backend: To upstream: Add attributes and bootstrap compiler a4b9e0d flambda-backend: Already upstreamed: stdlib capitalisation patch 4c1c259 flambda-backend: ocaml#9748 from xclerc/share-ev_defname (cherry-pick 3e937fcb562) 00027c4 flambda-backend: permanent/default-to-best-fit (cherry-pick 64240fd716a9d0db57d779ebe5b6f1a67704cdec) 2561dd9 flambda-backend: permanent/reraise-by-default (cherry-pick 50e94902ca6bb84c33982db858b74322eefd9af8) c0aa4f4 flambda-backend: permanent/gc-tuning (cherry-pick e9d6d2f145438dd6a82b56e9b41c8a01e752d81d) git-subtree-dir: ocaml git-subtree-split: 23a7f73

mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label Nov 15, 2021

mshinwell requested review from Gbury, chambart, gretay-js, lpw25, lthls, lukemaurer and xclerc as code owners November 15, 2021 09:58

xclerc approved these changes Nov 15, 2021

View reviewed changes

mshinwell force-pushed the flambda2-array-improvements branch from f0aae9b to 62e998d Compare November 15, 2021 15:31

lthls reviewed Nov 15, 2021

View reviewed changes

middle_end/flambda2/to_cmm/to_cmm.ml Outdated Show resolved Hide resolved

mshinwell force-pushed the flambda2-array-improvements branch 3 times, most recently from d3a003d to cefc7ba Compare November 15, 2021 17:52

lukemaurer approved these changes Nov 16, 2021

View reviewed changes

Gbury reviewed Nov 16, 2021

View reviewed changes

mshinwell requested a review from antalsz as a code owner December 3, 2021 10:58

mshinwell and others added 7 commits December 3, 2021 13:10

Improvements to array simplification

906e2ff

Promote test

8720a39

Improve comment and message

7e9f1e5

Bug fix

6a7bbbb

Comment

8ef769f

Update middle_end/flambda2/flambda2.ml

377075b

Co-authored-by: Guillaume Bury <[email protected]>

Update middle_end/flambda2/terms/flambda_primitive.ml

91083d6

Co-authored-by: Guillaume Bury <[email protected]>

mshinwell force-pushed the flambda2-array-improvements branch from 303db03 to 91083d6 Compare December 3, 2021 13:10

mshinwell added 3 commits December 3, 2021 13:15

Rebase fixes

8660476

Factor out duplicate code in Lambda_to_flambda_primitives

cbbc3c5

Rename arg_types

2efb929

mshinwell and others added 7 commits December 3, 2021 13:48

Use Or_unknown.t in Simplify_extcall

0671980

Use Cmm helper functions

705d75d

Comment about tag 0

38c74f9

element_kind

93b8ea6

Factor out specialisation logic; defer two CRs

26d3c0a

Remove use of the atom table in to_cmm_helper

1d80aa2

Fix lifting of empty arrays

ba7c1de

gretay-js approved these changes Dec 3, 2021

View reviewed changes

Gbury approved these changes Dec 3, 2021

View reviewed changes

lthls reviewed Dec 3, 2021

View reviewed changes

ocaml/lambda/printlambda.ml Show resolved Hide resolved

lthls approved these changes Dec 3, 2021

View reviewed changes

mshinwell merged commit de0707d into oxcaml:main Dec 3, 2021

mshinwell added a commit that referenced this pull request Dec 3, 2021

Improved simplification of array operations (#384)

fb84d22

mshinwell added a commit to mshinwell/oxcaml that referenced this pull request Dec 3, 2021

Improved simplification of array operations (oxcaml#384)

df3dafc

mshinwell added a commit that referenced this pull request Jan 14, 2022

Improved simplification of array operations (#384)

61336fc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved simplification of array operations#384

Improved simplification of array operations#384
mshinwell merged 17 commits intooxcaml:mainfrom
mshinwell:flambda2-array-improvements

mshinwell commented Nov 15, 2021

Uh oh!

mshinwell commented Nov 15, 2021

Uh oh!

xclerc left a comment

Uh oh!

mshinwell commented Nov 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mshinwell commented Dec 3, 2021

Uh oh!

gretay-js left a comment

Uh oh!

Uh oh!

lthls left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mshinwell commented Nov 15, 2021

Uh oh!

mshinwell commented Nov 15, 2021

Uh oh!

xclerc left a comment

Choose a reason for hiding this comment

Uh oh!

mshinwell commented Nov 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mshinwell commented Dec 3, 2021

Uh oh!

gretay-js left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lthls left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants