Fix race in Makefile caused by flags.sexp dependencies#32
Merged
mshinwell merged 1 commit intooxcaml:4.11from May 17, 2021
Merged
Fix race in Makefile caused by flags.sexp dependencies#32mshinwell merged 1 commit intooxcaml:4.11from
mshinwell merged 1 commit intooxcaml:4.11from
Conversation
Refactor all .sexp targets into flags.sexp.
gretay-js
force-pushed
the
fix-race-in-makefile
branch
from
277eef4 to
2569f6a
Compare
poechsel
pushed a commit
to poechsel/flambda-backend
that referenced
this pull request
May 26, 2021
Refactor all .sexp targets into flags.sexp.
poechsel
pushed a commit
to poechsel/flambda-backend
that referenced
this pull request
May 27, 2021
Refactor all .sexp targets into flags.sexp.
poechsel
pushed a commit
that referenced
this pull request
Jun 28, 2021
Refactor all .sexp targets into flags.sexp.
poechsel
pushed a commit
that referenced
this pull request
Jun 29, 2021
Refactor all .sexp targets into flags.sexp.
ccasin
added a commit
that referenced
this pull request
Jul 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The targets for oc_cflags.sexp, oc_cppflags.sexp and sharedlib_cflags.sexp all rerun config.status from stage1. This seems to cause intermittent build failures. Refactor the above .sexp rules into a single rule flags.sexp.