fix(no-nullable-type-assertion-style): use suggestion instead of fix#956
Merged
graphite-app[bot] merged 1 commit intoMay 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the non-nullable-type-assertion-style rule to emit a suggestion (with associated fixes) instead of providing an automatic fix, aligning the rule’s output with a “suggested fix” UX and updating tests/snapshots accordingly.
Changes:
- Switch rule reporting from
ReportNodeWithFixestoReportNodeWithSuggestions, packaging the existing fix operations as a single suggestion. - Update rule unit tests to assert suggestion output rather than auto-fix output.
- Update rule tester + e2e snapshots to reflect
suggestionsinstead of top-levelfixesin diagnostics.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/rules/non_nullable_type_assertion_style/non_nullable_type_assertion_style.go | Report non-null assertion conversion as a suggestion and consolidate fix construction. |
| internal/rules/non_nullable_type_assertion_style/non_nullable_type_assertion_style_test.go | Update invalid cases to validate suggestions (message + applied output) instead of auto-fix outputs. |
| internal/rule_tester/snapshots/non-nullable-type-assertion-style.snap | Refresh snapshots to include “Suggestion 1 …” lines for the rule tester output. |
| e2e/snapshots/snapshot.test.ts.snap | Refresh e2e snapshot JSON diagnostics to include suggestions instead of fixes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
changed the title
camc314
changed the title
Contributor
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
codex/non-nullable-type-assertion-suggestion
branch
from
cc84e82 to
8bd37ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #954