fix(prefer-nullish-coalescing): emit suggestion over fix#951
Merged
Conversation
camc314
changed the title
camc314
force-pushed
the
codex/prefer-nullish-suggestions
branch
from
a7737af to
64ca39d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts the prefer-nullish-coalescing rule to stop emitting auto-fixes and instead emit fix suggestions, reducing the risk of semantics-changing edits being applied implicitly (notably when replacing || with ?? can change behavior for falsy-but-non-nullish values like false).
Changes:
- Switched
prefer-nullish-coalescingfromReportNodeWithFixestoReportNodeWithSuggestionsfor||/||=, ternary, and assignment patterns. - Added a dedicated suggestion message id (
suggestNullishCoalescing) for the rule’s suggested fixes. - Updated rule tests and snapshots to assert suggestions (instead of fixed output) are produced.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/rules/prefer_nullish_coalescing/prefer_nullish_coalescing.go | Converts previously auto-applied fixes into explicit suggestions and adds a suggestion message. |
| internal/rules/prefer_nullish_coalescing/prefer_nullish_coalescing_test.go | Updates test expectations from Output autofix results to per-error Suggestions. |
| internal/rule_tester/snapshots/prefer-nullish-coalescing.snap | Refreshes snapshots to include the new suggestion entries in diagnostics output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
related to #950 this is technically unsafe in certain scenarios ``` const x: boolean | null | undefined; const y: true; // for `x = false`, `y = true`: `result = true` const result = x || y // for `x = false`, `y = true`: `result = false` const result = x ?? y ```
graphite-app
Bot
force-pushed
the
codex/prefer-nullish-suggestions
branch
from
0cdd8ca to
74e59a8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #950
this is technically unsafe in certain scenarios