fix(no-unsafe-enum-comparison): flag string literal unions#937
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the no-unsafe-enum-comparison rule to correctly detect unsafe comparisons when the non-enum side is a string-literal union (e.g. 'asc' | 'desc') being compared to a string enum member, and adds regression coverage for that case.
Changes:
- Extend primitive-like detection to traverse both union and intersection type parts when evaluating comparison safety.
- Add an invalid test case covering
string, named string-literal unions, and inline string-literal unions compared against a string enum member. - Update the rule snapshot to reflect the newly reported diagnostics.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/rules/no_unsafe_enum_comparison/no_unsafe_enum_comparison.go | Adds typeHasPrimitiveLikePart to detect primitive-like flags within union/intersection parts so comparisons against string-literal unions are flagged. |
| internal/rules/no_unsafe_enum_comparison/no_unsafe_enum_comparison_test.go | Adds a regression test ensuring string-literal unions compared to string enum members produce mismatchedCondition. |
| internal/rule_tester/snapshots/no-unsafe-enum-comparison.snap | Updates expected diagnostics output for the new invalid test case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
force-pushed
the
codex/fix-unsafe-enum-union-comparison
branch
2 times, most recently
from
40ae50d to
278ad0d
Compare
Contributor
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
codex/fix-unsafe-enum-union-comparison
branch
from
278ad0d to
8a2e65a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #934