feat(no-unnecessary-template-expression): implement fix#911
Merged
graphite-app[bot] merged 1 commit intoApr 26, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Implements an auto-fixer for the no-unnecessary-template-expression rule (part of #668) and updates/extends regression tests to validate the produced fixes.
Changes:
- Added fix generation for unnecessary template interpolations, including escaping/normalization handling for tricky literals (numbers, bigint, regex, nested templates,
${/`cases). - Updated rule tester cases to assert concrete
Outputvalues for invalid cases (including multi-pass fix outputs where applicable). - Updated snapshot expectations for newly added invalid test cases.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/rules/no_unnecessary_template_expression/no_unnecessary_template_expression.go | Adds fixer implementation and supporting helpers (escaping and canonicalization) for no-unnecessary-template-expression. |
| internal/rules/no_unnecessary_template_expression/no_unnecessary_template_expression_test.go | Converts previously commented-out expected outputs into asserted Output fields and adds new regression cases for numeric canonicalization and precedence. |
| internal/rule_tester/snapshots/no-unnecessary-template-expression.snap | Extends snapshot coverage for new invalid test cases added in the rule tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
force-pushed
the
codex/no-unnecessary-template-expression-fix
branch
2 times, most recently
from
8b5a41d to
d06576d
Compare
Contributor
Author
Merge activity
|
part of #668 Implements the fixer and regression tests.
graphite-app
Bot
force-pushed
the
codex/no-unnecessary-template-expression-fix
branch
from
d06576d to
73c15a2
Compare
graphite-app
Bot
deleted the
codex/no-unnecessary-template-expression-fix
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #668
Implements the fixer and regression tests.