fix: handle UTF-16 diagnostics#906
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the tsgolint CLI diagnostic printer when source files contain non-BMP characters (e.g., emoji), by avoiding invalid UTF-16 offset computations when deriving codebox slice boundaries.
Changes:
- Update
printDiagnosticto compute the codebox end position viascanner.GetECMAEndLinePosition(instead of manual column → UTF-16 offset conversion). - Fix off-by-one / out-of-bounds conditions when determining whether a diagnostic start/end falls within the current line.
- Add a regression test ensuring diagnostics can be printed for a source line containing UTF-16 characters.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/tsgolint/main.go | Adjusts diagnostic codebox boundary computation and fixes line-boundary checks to prevent panics. |
| cmd/tsgolint/main_test.go | Adds a regression test covering UTF-16 characters in diagnostic output generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
codex/fix-utf16-diagnostics
branch
from
48a0746 to
3858f4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897