chore: update typescript-go submodule#879
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the vendored typescript-go submodule and refreshes this repo’s compatibility layer (shims + local patch series) to align with upstream API/AST helper renames.
Changes:
- Refreshed generated shims to match upstream signature/type changes (project, checker, ast, lsproto).
- Updated rule/util call sites to use renamed AST helper predicates/casters (e.g.,
IsParameterDeclaration,AsTypeReferenceNode,AsTypeParameterDeclaration). - Rebasing/refreshing the
patches/*.patchseries and updating workspace sums after the submodule bump.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shim/project/shim.go | Updates NewSnapshot shim signature to match upstream preferences type change. |
| shim/lsp/lsproto/shim.go | Exposes newly added/renamed LSP protocol symbols via shim. |
| shim/checker/shim.go | Adds shim exports for new checker diagnostic helper APIs/types. |
| shim/ast/shim.go | Regenerates AST shim surface for upstream node/type/helper renames and additions. |
| internal/utils/ts_eslint.go | Updates type-parameter/type-reference casts and parameter predicate usage. |
| internal/utils/ts_api_utils.go | Updates rest-parameter detection to new predicate name. |
| internal/rules/unbound_method/unbound_method.go | Updates parameter checks for this and destructuring contexts. |
| internal/rules/prefer_return_this_type/prefer_return_this_type.go | Updates type-reference cast helper name. |
| internal/rules/prefer_readonly_parameter_types/prefer_readonly_parameter_types.go | Updates parameter predicate usage. |
| internal/rules/prefer_promise_reject_errors/prefer_promise_reject_errors.go | Updates parameter predicate usage. |
| internal/rules/only_throw_error/only_throw_error.go | Updates parameter predicate usage. |
| internal/rules/no_useless_default_assignment/no_useless_default_assignment.go | Updates parameter predicate usage in multiple code paths. |
| internal/rules/no_unnecessary_type_parameters/no_unnecessary_type_parameters.go | Updates type-parameter cast helper name. |
| internal/rules/no_unnecessary_type_arguments/no_unnecessary_type_arguments.go | Updates parameter predicate + type-parameter/type-reference cast helper names. |
| internal/rules/no_duplicate_type_constituents/no_duplicate_type_constituents.go | Updates parameter predicate usage. |
| patches/0001-Adapt-project-service-for-single-run-mode.patch | Refreshes patch metadata against new upstream base. |
| patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch | Refreshes patch metadata/hunk anchors against new upstream base. |
| patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Refreshes patch metadata against new upstream base. |
| patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch | Refreshes patch metadata against new upstream base. |
| patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch | Refreshes patch metadata against new upstream base. |
| go.work.sum | Updates workspace module sums due to dependency/submodule refresh. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
## Summary - update the `typescript-go` submodule from `c0703e66b68b826eedadce353d63fe9f4ea21fb6` to `886e854df8e86e2dda3f3a2518e5226f3cafcecc` - refresh the local `patches/*.patch` series against the new upstream base - regenerate shims and update TSGolint call sites for upstream AST helper renames ## Verification - `go test ./internal/...` against the refreshed patched submodule state - `just test` against the refreshed patched submodule state - CI workflows apply `patches/*.patch` before build/test via `.github/actions/setup`
graphite-app
Bot
force-pushed
the
update-typescript-go-20260410
branch
from
ca3b0d6 to
d3b6157
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript-gosubmodule fromc0703e66b68b826eedadce353d63fe9f4ea21fb6to886e854df8e86e2dda3f3a2518e5226f3cafceccpatches/*.patchseries against the new upstream baseVerification
go test ./internal/...against the refreshed patched submodule statejust testagainst the refreshed patched submodule statepatches/*.patchbefore build/test via.github/actions/setup