chore: improve assertion diagnostic msg#842
Merged
graphite-app[bot] merged 1 commit intoMar 27, 2026
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Improves failure diagnostics in the rule tester when a TypeScript source file cannot be retrieved from the created program, to aid debugging a flaky scenario.
Changes:
- Add
stringsimport to support formatting. - Replace a simple assertion with a richer failure path that reports the resolved filename and the program’s source file list (sorted).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge activity
|
For some reason this is flaky - I don't know why. This should aid debugging.
graphite-app
Bot
force-pushed
the
c/03-27-chore_improve_assertion_diagnostic_msg
branch
from
97ac8f6 to
2f8b5e8
Compare
graphite-app
Bot
deleted the
c/03-27-chore_improve_assertion_diagnostic_msg
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason this is flaky - I don't know why.
This should aid debugging.