chore: update typescript-go submodule#841
Merged
graphite-app[bot] merged 1 commit intoMar 27, 2026
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
commented
Mar 27, 2026
There was a problem hiding this comment.
Pull request overview
Updates the typescript-go submodule integration points (shims + local patch stack) to match upstream API changes and removes an outdated patch/fixture settings that are no longer needed with the newer submodule revision.
Changes:
- Refresh generated shim exports to align with updated
typescript-go/internal/*APIs (add/remove aliases and linkname stubs). - Rebase/renumber the local
patches/*.patchseries to apply cleanly on the updated submodule (and drop the old parallelreadDirectoryvisitor patch). - Adjust internal tsconfig resolution helper and e2e fixture tsconfigs for updated project/config behavior.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shim/vfs/shim.go | Removes previously exposed vfs matcher/linkname surface that’s no longer needed/available upstream. |
| shim/project/shim.go | Updates NewConfigFileRegistryBuilder shim signature to include customConfigFileName. |
| shim/lsp/lsproto/shim.go | Exposes newly added LSP custom method/types/constants from upstream. |
| shim/core/shim.go | Adds shim for GetSpellingSuggestionForStrings using iter.Seq. |
| shim/ast/shim.go | Exposes additional AST helpers/constants newly present upstream. |
| internal/utils/find_tsconfig.go | Updates builder construction call to match the new shimmed builder signature. |
| e2e/fixtures/circular-project-references/project1/tsconfig.json | Removes explicit moduleResolution to match updated compiler defaults/expectations. |
| e2e/fixtures/circular-project-references/project2/tsconfig.json | Removes explicit moduleResolution to match updated compiler defaults/expectations. |
| patches/0001-Adapt-project-service-for-single-run-mode.patch | Patch header updated for new base commit / series numbering. |
| patches/0002-patch-expose-more-functions-via-the-shim-with-type-f.patch | Patch rebased/updated to match new upstream code layout and exported names. |
| patches/0003-fix-early-return-from-invalid-tsconfig-for-better-er.patch | Patch header updated for new base commit / series numbering. |
| patches/0004-fix-collections-avoid-internal-json-import-in-ordere.patch | Patch header updated for new base commit / series numbering. |
| patches/0005-perf-vfs-cache-ReadFile-results-in-cachedvfs.patch | Patch header updated for new base commit / series numbering. |
| patches/0001-Parallel-readDirectory-visitor.patch | Removed from the patch stack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Merge activity
|
graphite-app
Bot
force-pushed
the
c/03-27-chore_update_typescript-go_submodule
branch
from
052e5f7 to
3680fb4
Compare
graphite-app
Bot
deleted the
c/03-27-chore_update_typescript-go_submodule
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.