feat: prefer nullish coalescing#494
Merged
camc314 merged 17 commits intooxc-project:mainfrom Dec 13, 2025
Merged
Conversation
…boolean instead of an object
kalvenschraut
force-pushed
the
feature/prefer-nullish-coalescing
branch
from
e559831 to
8fe74ef
Compare
Contributor
|
@kalvenschraut i've made some changes locally, can you allow edits by maintainers so I can get this merged? |
Contributor
|
Hi! I'm I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:
|
autofix.ci
Miodec
added a commit
to monkeytypegame/monkeytype
that referenced
this pull request
Dec 15, 2025
- main linting is now done by oxlint. eslint remains for linting json files in the frontend (until oxlint adds support) - move type checking to the lint step (with --type-check) this improves performance by removing a duplicated typescript parse task (instead of parsing for linting then again for type checking, it parses once for both) - add a `lint-fast` npm script to get some fast fail behavior. it simply lints with no type information - oxc plugins are still in preview, so the custom plugin that checks for `__testing` usage outside of tests runs outside the main linting job until performance is improved - fixes some type issues (and config issues) that were not visible due to a missing type check on some files. now type checking will run on every file that is linted - split up oxc config for easier management waiting oxc-project/tsgolint#494 seeing around 3x improvement in type aware linting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to my other PR, heavily made with AI. still a WIP putting up for any initial feedback would be appreciated, plan to review everything myself before marking as ready for review
closes #198