Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label 0-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
graphite-app
bot
changed the base branch from
c/09-08-test_add_test_for_linting_files_outside_a_project
to
graphite-base/216
graphite-app
bot
force-pushed
the
graphite-base/216
branch
from
b59efbc to
adde814
Compare
graphite-app
bot
force-pushed
the
c/09-08-perf_only_lint_included_files_not_all_project_files
branch
from
53520f0 to
f156349
Compare
graphite-app
bot
force-pushed
the
c/09-08-perf_only_lint_included_files_not_all_project_files
branch
from
f156349 to
38ea8f9
Compare
Boshen
force-pushed
the
c/09-08-perf_only_lint_included_files_not_all_project_files
branch
from
38ea8f9 to
d22faa2
Compare
`Program.SourceFiles()` includes **all** source files, including those from node_modules, builtin libs ect. However we don't need to lint these files. This PR changes the logic to only lint included files (over linting all files).
Boshen
force-pushed
the
c/09-08-perf_only_lint_included_files_not_all_project_files
branch
from
f518552 to
247cef7
Compare
Boshen
deleted the
c/09-08-perf_only_lint_included_files_not_all_project_files
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program.SourceFiles()includes all source files, including thosefrom node_modules, builtin libs ect. However we don't need to lint these
files. This PR changes the logic to only lint included files (over
linting all files).