feat(linter/eslint-plugin-vitest): Add prefer-spy-on as vitest compatible jest rule#291
Merged
camc314 merged 1 commit intooxc-project:mainfrom Dec 16, 2025
Conversation
camc314
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Dec 16, 2025
Related to #4656 Implement [prefer-spy-on](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-spy-on.md) lint ruler. ~~It's my first contribution made in Rust, and in Oxc, any suggestion to improve the code it's welcome. The logic is based on the JS rule implementation.~~ ~~Update 12/04/2025: I have just notice Jest have a similar linter rule, so I have duplicate the code and adapt it to vitest. I discarded the option to abstract all the logic as none can ensure that both lints rule are going to be the same in the future. Discarded the map between jest and vitest rules as the documentacion for this specific rule is distinct.~~ Update 12/15/2025: The rule is implemented as a compatible with jest instead of duplicate code: Oxlint migrate PR: oxc-project/oxlint-migrate#291
camc314
approved these changes
Dec 16, 2025
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Dec 16, 2025
Related to #4656 Implement [prefer-spy-on](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-spy-on.md) lint ruler. ~~It's my first contribution made in Rust, and in Oxc, any suggestion to improve the code it's welcome. The logic is based on the JS rule implementation.~~ ~~Update 12/04/2025: I have just notice Jest have a similar linter rule, so I have duplicate the code and adapt it to vitest. I discarded the option to abstract all the logic as none can ensure that both lints rule are going to be the same in the future. Discarded the map between jest and vitest rules as the documentacion for this specific rule is distinct.~~ Update 12/15/2025: The rule is implemented as a compatible with jest instead of duplicate code: Oxlint migrate PR: oxc-project/oxlint-migrate#291
qinyuhang
pushed a commit
to qinyuhang/oxc
that referenced
this pull request
Jan 22, 2026
…ct#16426) Related to oxc-project#4656 Implement [prefer-spy-on](https://github.com/vitest-dev/eslint-plugin-vitest/blob/main/docs/rules/prefer-spy-on.md) lint ruler. ~~It's my first contribution made in Rust, and in Oxc, any suggestion to improve the code it's welcome. The logic is based on the JS rule implementation.~~ ~~Update 12/04/2025: I have just notice Jest have a similar linter rule, so I have duplicate the code and adapt it to vitest. I discarded the option to abstract all the logic as none can ensure that both lints rule are going to be the same in the future. Discarded the map between jest and vitest rules as the documentacion for this specific rule is distinct.~~ Update 12/15/2025: The rule is implemented as a compatible with jest instead of duplicate code: Oxlint migrate PR: oxc-project/oxlint-migrate#291
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.