Skip to content

fix: correct assignment operators#192

Merged
Sysix merged 2 commits intooxc-project:mainfrom
quanquan2100:fix/assignment-operators
Sep 16, 2025
Merged

fix: correct assignment operators#192
Sysix merged 2 commits intooxc-project:mainfrom
quanquan2100:fix/assignment-operators

Conversation

@quanquan2100
Copy link
Copy Markdown
Contributor

This PR fixes a bug where comparison operators (==) were mistakenly used instead of assignment operators (=) in the normalizeSeverityValue function.

This question seems strange, was it intended to be that way? 🤔

@Boshen
Copy link
Copy Markdown
Member

Boshen commented Sep 16, 2025

How come there is no default lint rule to detect this 🤔

@quanquan2100
Copy link
Copy Markdown
Contributor Author

@Boshen
Copy link
Copy Markdown
Member

Boshen commented Sep 16, 2025

Thank you, raised oxc-project/oxc#13796

@Boshen Boshen requested a review from Sysix September 16, 2025 03:32
Copy link
Copy Markdown
Member

@Sysix Sysix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Sysix Sysix merged commit bf46aef into oxc-project:main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants