Revert "apply borrow builder pattern to ConcatSourceMapBuilder (#366)"#370
Merged
Conversation
This reverts commit 8d72a6a.
Merging this PR will improve performance by 1.93%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #366 (and #369, which sits on top of it).
#366 switched
ConcatSourceMapBuilderto borrowed&'a strstorage — optimal when the input maps outlive the result. But the builder's main consumer, rolldown'sSourceJoiner, feeds ownedSourceMap<'static>maps and wants an owned map back. The right optimization there is owned-merge — move the owned strings into the builder (no copy) — which needsCowstorage, not&str.This restores the original
Cow<'a, str>storage so the owned-merge work can land on top (#368, mirroring the approach in #365). #369's benchmark is reverted alongside because it callsConcatSourceMapBuilder::into_owned_sourcemap(added by #366); #368 reintroduces a superset of those benches on the restored storage.