Skip to content

Comments

fix: re-calculate CachedPathImpl::parent and CachedPathImpl::node_modules if the cache is dropped#817

Closed
sapphi-red wants to merge 1 commit intomainfrom
11-07-fix_re-calculate_cachedpathimpl_parent_and_cachedpathimpl_node_modules_if_the_cache_is_dropped
Closed

fix: re-calculate CachedPathImpl::parent and CachedPathImpl::node_modules if the cache is dropped#817
sapphi-red wants to merge 1 commit intomainfrom
11-07-fix_re-calculate_cachedpathimpl_parent_and_cachedpathimpl_node_modules_if_the_cache_is_dropped

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 6, 2025 •
edited
Loading

This PR is similar to #791 but for CachedPathImpl::parent and CachedPathImpl::node_modules.

This PR aims to fix the flaky failure like https://github.com/vitejs/rolldown-vite/actions/runs/19126439595/job/54657469579#step:11:216

@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Nov 6, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.12%. Comparing base (6b1c9ed) to head (edc530a).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
src/cache/cached_path.rs 83.33% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #817      +/-   ##
==========================================
- Coverage   94.26%   94.12%   -0.15%     
==========================================
  Files          17       17              
  Lines        3071     3098      +27     
==========================================
+ Hits         2895     2916      +21     
- Misses        176      182       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sapphi-red sapphi-red requested a review from Boshen November 6, 2025 17:57
@sapphi-red sapphi-red mentioned this pull request Nov 6, 2025
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #817 will not alter performance

Comparing 11-07-fix_re-calculate_cachedpathimpl_parent_and_cachedpathimpl_node_modules_if_the_cache_is_dropped (edc530a) with main (6b1c9ed)

Summary

✅ 10 untouched
⏩ 5 skipped1

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sapphi-red sapphi-red marked this pull request as ready for review November 6, 2025 18:22
@Boshen
Copy link
Member

Boshen commented Nov 8, 2025

I need to rethink the architecture.

@Boshen Boshen marked this pull request as draft November 8, 2025 03:56
@Boshen Boshen mentioned this pull request Nov 25, 2025
Closed
@Boshen
Copy link
Member

Boshen commented Nov 25, 2025

Moving to #872 for now, is this still a blocking issue?

@Boshen Boshen closed this Nov 25, 2025
graphite-app bot pushed a commit to rolldown/rolldown that referenced this pull request Dec 3, 2025
@sapphi-red
feat(plugin/vite-resolve): add disableCache option (#6763)
c44a9c9 
For vitejs/rolldown-vite#466

requires oxc-project/oxc-resolver#791, oxc-project/oxc-resolver#817, oxc-project/oxc-resolver#872
@Boshen Boshen deleted the 11-07-fix_re-calculate_cachedpathimpl_parent_and_cachedpathimpl_node_modules_if_the_cache_is_dropped branch December 18, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Awaiting requested review from Boshen

Assignees

@Boshen Boshen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sapphi-red @Boshen