fix: allow resolving package?query#fragment for packages with exports field#655
Merged
graphite-app[bot] merged 1 commit intomainfrom Aug 20, 2025
Conversation
This was referenced Aug 20, 2025
Member
Author
How to use the Graphite Merge QueueAdd the label merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
- Coverage 94.97% 94.95% -0.02%
==========================================
Files 12 12
Lines 2824 2816 -8
==========================================
- Hits 2682 2674 -8
Misses 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #655 will not alter performanceComparing Summary
|
Member
Merge activity
|
…ts field (#655) Resolving `package?query#fragment` to packages with exports field is allowed in Vite to allow things like `css-package?url`, `wasm-package?init`. This was not allowed by oxc-resolver and this PR allows that. The current behavior of oxc-resolver comes from this change in enhanced-resolve (webpack/enhanced-resolve#225). This PR adds tests that disallows `pkg?foo` but allows `pkg/nested?foo`. This current behavior doesn't make sense to me. Both `pkg?foo` and `pkg/nested?foo` are not allowed by Node and I don't find a reason to treat them differently. fixes vitejs/rolldown-vite#382 refs 97dfb1a
graphite-app
bot
force-pushed
the
08-20-test_make_tests_pass_on_windows
branch
from
921171e to
6f7e505
Compare
graphite-app
bot
force-pushed
the
08-20-fix_allow_resolving_package_query_fragment_for_packages_with_exports_field
branch
from
23eeae2 to
c635417
Compare
graphite-app
bot
deleted the
08-20-fix_allow_resolving_package_query_fragment_for_packages_with_exports_field
branch
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Aug 21, 2025
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving
package?query#fragmentto packages with exports field is allowed in Vite to allow things likecss-package?url,wasm-package?init. This was not allowed by oxc-resolver and this PR allows that.The current behavior of oxc-resolver comes from this change in enhanced-resolve (webpack/enhanced-resolve#225). This PR adds tests that disallows
pkg?foobut allowspkg/nested?foo.This current behavior doesn't make sense to me. Both
pkg?fooandpkg/nested?fooare not allowed by Node and I don't find a reason to treat them differently.fixes vitejs/rolldown-vite#382
refs 97dfb1a