Skip to content

Comments

test: make tests pass on Windows#654

Merged
graphite-app[bot] merged 1 commit intomainfrom
08-20-test_make_tests_pass_on_windows
Aug 20, 2025
Merged

test: make tests pass on Windows#654
graphite-app[bot] merged 1 commit intomainfrom
08-20-test_make_tests_pass_on_windows

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 20, 2025 •
edited
Loading

Made tests pass on Windows. I commented out the failing ones for now.

@sapphi-red sapphi-red mentioned this pull request Aug 20, 2025
Merged
@sapphi-red Graphite App
Copy link
Member Author

sapphi-red commented Aug 20, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red marked this pull request as ready for review August 20, 2025 10:41
@codecov
Copy link

codecov bot commented Aug 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.97%. Comparing base (544135b) to head (6f7e505).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #654   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files          12       12           
  Lines        2824     2824           
=======================================
  Hits         2682     2682           
  Misses        142      142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 20, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #654 will not alter performance

Comparing 08-20-test_make_tests_pass_on_windows (6f7e505) with main (544135b)1

Summary

✅ 3 untouched benchmarks

Footnotes

  1. No successful run was found on main (d9ff77a) during the generation of this report, so 544135b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@sapphi-red sapphi-red mentioned this pull request Aug 20, 2025
Merged
@graphite-app graphite-app bot added the merge label Aug 20, 2025
@graphite-app
Copy link

graphite-app bot commented Aug 20, 2025 •
edited
Loading

Merge activity

@sapphi-red
test: make tests pass on Windows (#654)
6f7e505 
Made tests pass on Windows. I commented out the failing ones for now.
@graphite-app graphite-app bot force-pushed the 08-20-chore_support_windows_shell_for_just branch from 4e1559e to d9ff77a Compare August 20, 2025 15:21
@graphite-app graphite-app bot force-pushed the 08-20-test_make_tests_pass_on_windows branch from 921171e to 6f7e505 Compare August 20, 2025 15:22
Base automatically changed from 08-20-chore_support_windows_shell_for_just to main August 20, 2025 15:24
@graphite-app graphite-app bot removed the merge label Aug 20, 2025
@graphite-app graphite-app bot merged commit 6f7e505 into main Aug 20, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 08-20-test_make_tests_pass_on_windows branch August 20, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sapphi-red