chore: remove test and JS-side leftovers#1271
Conversation
- Delete a byte-identical duplicated row in the resolve() test table (the upstream enhanced-resolve test has the case exactly once). - Drop a `clippy::too_many_lines` allow in the alias test that no longer suppresses anything. - Dedupe a repeated "napi/browser.js" fmt ignore entry, remove a stale copy-pasted comment in napi/test.mjs, and an inert eslint-disable directive in webcontainer-fallback.js.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
=======================================
Coverage 94.04% 94.04%
=======================================
Files 21 21
Lines 4267 4267
=======================================
Hits 4013 4013
Misses 254 254 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4522690a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merging this PR will not alter performance
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing 
Footnotes
|
1 participant
Small leftovers found while sweeping the test suite and the JS side:
src/tests/resolve.rs: the "file in module with query and fragment" table row appeared twice, byte-identical — the upstream enhanced-resolveresolve.test.jshas the case exactly once, so the second row was a copy-paste in the port. The loop just ran the same assertion twice.src/tests/alias.rs:#[allow(clippy::too_many_lines)]no longer suppresses anything (verified by removing it and running the CI clippy command). The same allow inimports_field.rsis still load-bearing (1191/100) and stays.vite.config.ts:"napi/browser.js"was listed twice infmt.ignorePatterns.napi/test.mjs: removed a stale comment about a.tsextension next to code that adds.mjsand resolves an already-suffixed specifier.napi/webcontainer-fallback.js: removed an inert lint directive (// eslint-disable-next-line: no-console) — the project lints with oxlint, the syntax is invalid even for ESLint, andno-consoleisn't enabled.Part of a second cleanup pass; follows #1264–#1268.