feat: support notes for diagnostics#124
Merged
Merged
Conversation
spanishpear
commented
Jan 1, 2026
spanishpear
commented
Jan 1, 2026
Contributor
Author
|
@Boshen When you get a moment, could I get CI perms? 😁 Thanks! Happy new year! |
Boshen
reviewed
Jan 1, 2026
Boshen
left a comment
Boshen
left a comment
Member
There was a problem hiding this comment.
LGTM. You can use github ref in your Oxc PR first, we'll merge and release this after everything works.
camc314
approved these changes
Jan 4, 2026
camc314
changed the title
notes for diagnostics
Merged
camc314
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Jan 5, 2026
Consumes miette changes in oxc-project/oxc-miette#124 for #17443 For now, simple `note` field with appropriate `note()` and `with_note()` helpers --------- Signed-off-by: Shrey Sudhir <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
notefield ondiagnosticNotes
#[diagnostic(note = "...")]or#[note("...")]on a field) - will do that afterwardsNeeded for oxc-project/oxc#17443
Disclaimer, AI was used for generating tests for the changes, given the existing tests in the repo.