• refactor(ast_tools/estree): re-order custom serializers #9945
• refactor(ast/estree): shorten raw deser code #9944 👈 (View in Graphite)
• refactor(ast/estree): expose INCLUDE_TS_FIELDS constant on Serializer #9943
• fix(ast/estree): fix TS type def for TSThisParameter #9942
• fix(ast/estree): fix Function.this_param #9913
• fix(ast/extree): fix TSModuleDeclaration.global #9941
• main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

This stack of pull requests is managed by Graphite. Learn more about stacking.

CodSpeed Instrumentation Performance Report

Merging #9944 will not alter performance

_{Comparing 03-21-refactor_ast_estree_shorten_raw_deser_code (db642eb) with main (dc3e725)}

Summary

✅ 33 untouched benchmarks

@hi-ogawa This may be of interest to you. THIS is usually preferable to DESER, where possible.

You can generally use THIS unless one of:

1. The field you want the value of is the one which you're converting. i.e. if the converter is for foo field, you can't use THIS.foo in that converter (as it'd be circular logic).
2. The field you want to get the value of is marked #[estree(skip)].
3. The other field is later than current field in the struct. (sometimes this is fine, but sometimes not)

I will at some point overhaul these "macros" in raw_deser definitions to make them much simpler, and remove the above restrictions. But for now, this is how it is.

Merge activity

• Mar 21, 3:51 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Mar 21, 3:51 AM EDT: A user added this pull request to the Graphite merge queue.
• Mar 21, 4:03 AM EDT: A user merged this pull request with the Graphite merge queue.

Thanks! I wasn't aware of THIS. Good to know 👍