fix(ast/extree): fix TSModuleDeclaration.global#9907
Merged
overlookmotel merged 1 commit intographite-base/9907from Mar 21, 2025
Merged
Conversation
This was referenced Mar 20, 2025
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9907 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
graphite-app
bot
changed the base branch from
03-17-fix_ast_estree_fix_class.id_
to
graphite-base/9907
overlookmotel
approved these changes
Mar 21, 2025
Member
overlookmotel
left a comment
overlookmotel
left a comment
There was a problem hiding this comment.
I think the way you've done it here is good. Even if the field is deprecated, it still exists in TS-ESLint AST, and some code may rely on it. So we should match that.
Member
Merge activity
|
overlookmotel
added
0-merge
Member
|
You going to merge this or what, Mr Graphite? |
overlookmotel
deleted the
03-20-fix_ast_extree_fix_tsmoduledeclaration.global_
branch
Member
|
Graphite got stuck. I've merged manually. |
graphite-app bot
pushed a commit
that referenced
this pull request
Mar 21, 2025
This is a copy of #9907. For some reason Graphite bungled things up, and that PR got merged into the wrong branch. spec: https://github.com/typescript-eslint/typescript-eslint/blob/6428670b94de0027189803e5a291858d2e45362d/packages/ast-spec/src/declaration/TSModuleDeclaration/spec.ts#L26-L36 It looks like this is a deprecated property as its redundant. I thought of removing it in https://github.com/oxc-project/acorn-test262, but that means I need to modify 10K files there, so I went with fixing this side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spec: https://github.com/typescript-eslint/typescript-eslint/blob/6428670b94de0027189803e5a291858d2e45362d/packages/ast-spec/src/declaration/TSModuleDeclaration/spec.ts#L26-L36
It looks like this is a deprecated property as its redundant. I thought of removing it in https://github.com/oxc-project/acorn-test262, but that means I need to modify 10K files there, so I went with fixing this side.