perf(ast/estree): speed up raw deser for JSXElement#9895
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 19, 2025
Merged
Conversation
github-actions
bot
added
A-ast
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9895 will not alter performanceComparing Summary
|
Member
Author
|
Makes no difference to output, and should be a perf improvement (though we don't have benchmarks to answer that one), so merging without review. |
Member
Author
Merge activity
|
Follow-on after #9863. Speed up the raw deserializer code for `JSXElement` that PR introduced. Using `delete` in JS is usually a deoptimization. Better to create a new object.
graphite-app
bot
force-pushed
the
03-19-perf_ast_estree_speed_up_raw_deser_for_jsxelement_
branch
from
78d3dd1 to
5f97f28
Compare
graphite-app
bot
deleted the
03-19-perf_ast_estree_speed_up_raw_deser_for_jsxelement_
branch
Boshen
added a commit
that referenced
this pull request
Mar 20, 2025
## [0.61.0] - 2025-03-20 - c631291 parser: [**BREAKING**] Parse `TSImportAttributes` as `ObjectExpression` (#9902) (Boshen) - eef7eb6 minifier: [**BREAKING**] Rename `CompressOptions::all_true`/`all_false` to `smallest`/`safest` (#9866) (sapphi-red) ### Features - 38ad787 data_structures: Add `assert_unchecked!` macro (#9885) (overlookmotel) - dcd356e minifier: Support `keep_names` option (#9867) (sapphi-red) - 6565fc4 napi: Feature gate allocator (#9921) (Boshen) - 2cedfe4 napi: Add codeframe to napi error (#9893) (Boshen) - a9a47a6 parser: Add regex cargo feature to oxc_parser (#9879) (Toshit) - d4a83ba parser: Report duplicate modifier `Accessibility modifier already seen.` (#9890) (Boshen) - 59c8f71 parser,codegen: Handle lone surrogate in string literal (#9918) (Boshen) ### Bug Fixes - 28a2ed3 estree/ast: Fix `IdentifierName` and `IdentifierReference` (#9863) (hi-ogawa) - 3d4c5f3 semantic: Correctly visit `IfStmt` `test` when building cfg (#9864) (camc314) - 1774225 transformer/using: Incorrect scope ids for bindings (#9871) (camc314)- 68018e1 Ast changes (Boshen) ### Performance - 5f97f28 ast/estree: Speed up raw deser for `JSXElement` (#9895) (overlookmotel) - b272893 mangler, minifier: Initialize a Vec with a specific value using `Vec::from_iter_in` combined with `repeat_with` (#9908) (Dunqing) - f7d078c semantic: Use `reserve_exact` instead of `reserve` to save memory in pre-reserve (#9910) (Dunqing) ### Documentation - 590a258 napi/parser: Add stackblitz link for wasm build (Boshen) ### Refactor - 62e2859 ast/ast_builder: Use `self.vec_from_iter` instead of `Vec::from_iter_in` for consistency (#9909) (Dunqing) - b2f3d23 isolated_declarations: Remove unused `self` params (#9868) (overlookmotel) - 961b95d napi: Move common code to `oxc_napi` (#9875) (Boshen) - 233c1fc napi/playground: Add JSON.parse wrapper (#9880) (Hiroshi Ogawa) - dbe61c5 transformer/module-runner-transform: Remove redundant converison (#9912) (Dunqing) - ecdfe2e transformer/using: Move work to `exit_static_block` (#9713) (camc314) ### Testing - 9314147 data_structures: Enable doc tests for `oxc_data_structures` crate (#9884) (overlookmotel) - 040e993 napi: Refactor NAPI parser benchmarks (#9911) (overlookmotel) - e637e2e napi/parser: Tweak vitest config (#9878) (Hiroshi Ogawa) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #9863. Speed up the raw deserializer code for
JSXElementthat PR introduced. Usingdeletein JS is usually a deoptimization. Better to create a new object.