fix(linter/react): exhaustive-deps report longest dependency#9891
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 20, 2025
Merged
Conversation
This was referenced Mar 19, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9891 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
03-19-feat_data_structures_add_assert_unchecked_macro
to
graphite-base/9891
graphite-app
bot
force-pushed
the
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
branch
from
5730da9 to
cb0e6b7
Compare
graphite-app
bot
force-pushed
the
graphite-base/9891
branch
from
e1cd1a7 to
38ad787
Compare
graphite-app
bot
force-pushed
the
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
branch
from
cb0e6b7 to
61aba28
Compare
Sysix
approved these changes
Mar 19, 2025
Member
Merge activity
|
Where a hook has multiple overlapping dependencies, `react/exhaustive-deps` rule reports that overlap. e.g.:
```js
function Foo(props) {
useCallback(() => {
console.log(props.foo);
}, [props, props.foo]);
return <div />;
}
```
```
eslint-plugin-react(exhaustive-deps): React Hook useCallback has unnecessary dependency: props.foo
```
[eslint-plugin-react-hooks](https://www.npmjs.com/package/eslint-plugin-react-hooks) always reports the longest dependency (`props.foo` in above case). Whereas Oxlint would report either `props` or `props.foo` randomly - because the dependencies are stored in an `FxHashSet` which does not have a defined iteration order.
This PR fixes that so it always reports the longer dependency, aligning with the ESLint plugin.
graphite-app
bot
force-pushed
the
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
branch
from
61aba28 to
2e023ab
Compare
graphite-app
bot
deleted the
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where a hook has multiple overlapping dependencies,
react/exhaustive-depsrule reports that overlap. e.g.:eslint-plugin-react-hooks always reports the longest dependency (
props.fooin above case). Whereas Oxlint would report eitherpropsorprops.foorandomly - because the dependencies are stored in anFxHashSetwhich does not have a defined iteration order.This PR fixes that so it always reports the longer dependency, aligning with the ESLint plugin.