feat(data_structures): zero-cost NonMaxU32 type#9883
Closed
overlookmotel wants to merge 1 commit intomainfrom
Closed
feat(data_structures): zero-cost NonMaxU32 type#9883overlookmotel wants to merge 1 commit intomainfrom
NonMaxU32 type#9883overlookmotel wants to merge 1 commit intomainfrom
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9883 will not alter performanceComparing Summary
|
Base automatically changed from
03-19-ci_miri_run_miri_on_oxc_data_structures_crate_with_all_features_enabled
to
main
March 19, 2025 04:53
overlookmotel
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
99c72e2 to
faf48ce
Compare
overlookmotel
changed the base branch from
graphite-base/9883
to
03-19-feat_data_structures_add_assert_unchecked_macro
This was referenced Mar 19, 2025
overlookmotel
force-pushed
the
03-19-feat_data_structures_add_assert_unchecked_macro
branch
from
2ded941 to
e1cd1a7
Compare
overlookmotel
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
faf48ce to
513f5ec
Compare
overlookmotel
changed the base branch from
03-19-feat_data_structures_add_assert_unchecked_macro
to
graphite-base/9883
overlookmotel
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
513f5ec to
9694667
Compare
overlookmotel
changed the base branch from
graphite-base/9883
to
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
graphite-app
bot
force-pushed
the
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
branch
2 times, most recently
from
cb0e6b7 to
61aba28
Compare
graphite-app
bot
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
9694667 to
a111895
Compare
graphite-app
bot
changed the base branch from
03-19-fix_linter_react_exhaustive-deps_report_longest_dependency
to
graphite-base/9883
graphite-app
bot
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
a111895 to
40ea7e0
Compare
graphite-app
bot
force-pushed
the
graphite-base/9883
branch
from
61aba28 to
2e023ab
Compare
graphite-app
bot
force-pushed
the
03-19-feat_data_structures_zero-cost_nonmaxu32_type
branch
from
40ea7e0 to
4d4a502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce our own
NonMaxU32type.This version has an advantage over nonmax's version on Linux, Mac and WASI. On those platforms, it utilizes the
std::os::fd::BorrowedFdtype, which is a true non-max type. Therefore, conversion to/fromu32is completely zero cost, whereas previous version stores the number as aNonZeroU32and has to performn ^ u32::MAXon every read/write.NonMaxU32has a niche, soOption<NonMaxU32>is 4 bytes.On platforms which don't have
std::os::fd::BorrowedFd(Windows), we fallback to an implementation which usesNonZeroU32internally, same as before.