Skip to content

Comments

fix(estree/ast): fix IdentifierName and IdentifierReference#9863

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-18-fix_estree_ast_fix_identifiername_and_identifierreference_
Mar 19, 2025
Merged

fix(estree/ast): fix IdentifierName and IdentifierReference#9863
graphite-app[bot] merged 1 commit intomainfrom
03-18-fix_estree_ast_fix_identifiername_and_identifierreference_

Conversation

@hi-ogawa
Copy link
Contributor

@hi-ogawa hi-ogawa commented Mar 18, 2025

Binding side is tricky #9822, so I went with chipping away these two first.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Mar 18, 2025
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hi-ogawa hi-ogawa marked this pull request as ready for review March 18, 2025 10:04
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #9863 will degrade performances by 8.26%

Comparing 03-18-fix_estree_ast_fix_identifiername_and_identifierreference_ (28a2ed3) with main (8e3d9be)

Summary

❌ 1 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
estree[checker.ts] 87.5 ms 95.4 ms -8.26%

@hi-ogawa hi-ogawa marked this pull request as draft March 19, 2025 00:55
@hi-ogawa hi-ogawa force-pushed the 03-18-fix_estree_ast_fix_identifiername_and_identifierreference_ branch 3 times, most recently from ae71f5f to 66c1c2b Compare March 19, 2025 07:36
@hi-ogawa hi-ogawa marked this pull request as ready for review March 19, 2025 07:43
@hi-ogawa hi-ogawa force-pushed the 03-18-fix_estree_ast_fix_identifiername_and_identifierreference_ branch from 66c1c2b to 9f10d23 Compare March 19, 2025 07:44
@Boshen Boshen requested a review from overlookmotel March 19, 2025 08:50
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 19, 2025
Copy link
Member

overlookmotel commented Mar 19, 2025

Merge activity

  • Mar 19, 7:39 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 19, 7:39 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 19, 7:46 AM EDT: A user merged this pull request with the Graphite merge queue.

Binding side is tricky #9822, so I went with chipping away these two first.
@graphite-app graphite-app bot force-pushed the 03-18-fix_estree_ast_fix_identifiername_and_identifierreference_ branch from 9f10d23 to 28a2ed3 Compare March 19, 2025 11:39
@graphite-app graphite-app bot merged commit 28a2ed3 into main Mar 19, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 03-18-fix_estree_ast_fix_identifiername_and_identifierreference_ branch March 19, 2025 11:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 19, 2025
graphite-app bot pushed a commit that referenced this pull request Mar 19, 2025
Follow-on after #9863. Speed up the raw deserializer code for `JSXElement` that PR introduced. Using `delete` in JS is usually a deoptimization. Better to create a new object.
Boshen added a commit that referenced this pull request Mar 20, 2025
## [0.61.0] - 2025-03-20

- c631291 parser: [**BREAKING**] Parse `TSImportAttributes` as
`ObjectExpression` (#9902) (Boshen)

- eef7eb6 minifier: [**BREAKING**] Rename
`CompressOptions::all_true`/`all_false` to `smallest`/`safest` (#9866)
(sapphi-red)

### Features

- 38ad787 data_structures: Add `assert_unchecked!` macro (#9885)
(overlookmotel)
- dcd356e minifier: Support `keep_names` option (#9867) (sapphi-red)
- 6565fc4 napi: Feature gate allocator (#9921) (Boshen)
- 2cedfe4 napi: Add codeframe to napi error (#9893) (Boshen)
- a9a47a6 parser: Add regex cargo feature to oxc_parser (#9879) (Toshit)
- d4a83ba parser: Report duplicate modifier `Accessibility modifier
already seen.` (#9890) (Boshen)
- 59c8f71 parser,codegen: Handle lone surrogate in string literal
(#9918) (Boshen)

### Bug Fixes

- 28a2ed3 estree/ast: Fix `IdentifierName` and `IdentifierReference`
(#9863) (hi-ogawa)
- 3d4c5f3 semantic: Correctly visit `IfStmt` `test` when building cfg
(#9864) (camc314)
- 1774225 transformer/using: Incorrect scope ids for bindings (#9871)
(camc314)- 68018e1 Ast changes (Boshen)

### Performance

- 5f97f28 ast/estree: Speed up raw deser for `JSXElement` (#9895)
(overlookmotel)
- b272893 mangler, minifier: Initialize a Vec with a specific value
using `Vec::from_iter_in` combined with `repeat_with` (#9908) (Dunqing)
- f7d078c semantic: Use `reserve_exact` instead of `reserve` to save
memory in pre-reserve (#9910) (Dunqing)

### Documentation

- 590a258 napi/parser: Add stackblitz link for wasm build (Boshen)

### Refactor

- 62e2859 ast/ast_builder: Use `self.vec_from_iter` instead of
`Vec::from_iter_in` for consistency (#9909) (Dunqing)
- b2f3d23 isolated_declarations: Remove unused `self` params (#9868)
(overlookmotel)
- 961b95d napi: Move common code to `oxc_napi` (#9875) (Boshen)
- 233c1fc napi/playground: Add JSON.parse wrapper (#9880) (Hiroshi
Ogawa)
- dbe61c5 transformer/module-runner-transform: Remove redundant
converison (#9912) (Dunqing)
- ecdfe2e transformer/using: Move work to `exit_static_block` (#9713)
(camc314)

### Testing

- 9314147 data_structures: Enable doc tests for `oxc_data_structures`
crate (#9884) (overlookmotel)
- 040e993 napi: Refactor NAPI parser benchmarks (#9911) (overlookmotel)
- e637e2e napi/parser: Tweak vitest config (#9878) (Hiroshi Ogawa)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants