test(ast/estree): ignore field order difference from typescript-eslint by hi-ogawa · Pull Request #9813 · oxc-project/oxc

hi-ogawa · 2025-03-17T03:23:33Z

Part of #9705

This doesn't magically improve passes, but it makes it easier to digest mismatch diff.

tasks/coverage/acorn-test262-diff/typescript/tests/cases/compiler/2dArrays.diff

@@ -20,12 +20,12 @@
         "type": "Identifier",
         "start": 6,
         "end": 10,
-        "decorators": [],
-        "name": "Cell",
-        "optional": false
+        "name": "Cell"
       },
-      "implements": [],
-      "superClass": null
+      "implements": null,
+      "superClass": null,
+      "superTypeParameters": null,
+      "typeParameters": null
     },
     {
       "type": "ClassDeclaration",
@@ -41,6 +41,7 @@
             "type": "PropertyDefinition",
             "start": 33,
             "end": 49,
+            "accessibility": null,
             "computed": false,
             "declare": false,
             "decorators": [],
@@ -49,9 +50,7 @@
               "type": "Identifier",
               "start": 33,
               "end": 39,
-              "decorators": [],
-              "name": "isSunk",
-              "optional": false
+              "name": "isSunk"
             },
             "optional": false,
             "override": false,
@@ -77,12 +76,12 @@
         "type": "Identifier",
         "start": 22,
         "end": 26,
-        "decorators": [],
-        "name": "Ship",
-        "optional": false
+        "name": "Ship"
       },
-      "implements": [],
-      "superClass": null
+      "implements": null,
+      "superClass": null,
+      "superTypeParameters": null,
+      "typeParameters": null
     },
     {
       "type": "ClassDeclaration",
@@ -98,6 +97,7 @@
             "type": "PropertyDefinition",
             "start": 71,
             "end": 85,
+            "accessibility": null,
             "computed": false,
             "declare": false,
             "decorators": [],
@@ -106,9 +106,7 @@
               "type": "Identifier",
               "start": 71,
               "end": 76,
-              "decorators": [],
-              "name": "ships",
-              "optional": false
+              "name": "ships"
             },
             "optional": false,
             "override": false,
@@ -130,10 +128,9 @@
                     "type": "Identifier",
                     "start": 78,
                     "end": 82,
-                    "decorators": [],
-                    "name": "Ship",
-                    "optional": false
-                  }
+                    "name": "Ship"
+                  },
+                  "typeParameters": null
                 }
               }
             },
@@ -143,6 +140,7 @@
             "type": "PropertyDefinition",
             "start": 90,
             "end": 104,
+            "accessibility": null,
             "computed": false,
             "declare": false,
             "decorators": [],
@@ -151,9 +149,7 @@
               "type": "Identifier",
               "start": 90,
               "end": 95,
-              "decorators": [],
-              "name": "cells",
-              "optional": false
+              "name": "cells"
             },
             "optional": false,
             "override": false,
@@ -175,10 +171,9 @@
                     "type": "Identifier",
                     "start": 97,
                     "end": 101,
-                    "decorators": [],
-                    "name": "Cell",
-                    "optional": false
-                  }
+                    "name": "Cell"
+                  },
+                  "typeParameters": null
                 }
               }
             },
@@ -195,9 +190,7 @@
               "type": "Identifier",
               "start": 118,
               "end": 130,
-              "decorators": [],
-              "name": "allShipsSunk",
-              "optional": false
+              "name": "allShipsSunk"
             },
             "kind": "method",
             "optional": false,
@@ -245,18 +238,14 @@
                                     "type": "Identifier",
                                     "start": 191,
                                     "end": 194,
-                                    "decorators": [],
-                                    "name": "val",
-                                    "optional": false
+                                    "name": "val"
                                   },
                                   "optional": false,
                                   "property": {
                                     "type": "Identifier",
                                     "start": 195,
                                     "end": 201,
-                                    "decorators": [],
-                                    "name": "isSunk",
-                                    "optional": false
+                                    "name": "isSunk"
                                   }
                                 }
                               }
@@ -271,11 +260,18 @@
                               "type": "Identifier",
                               "start": 177,
                               "end": 180,
+                              "accessibility": null,
                               "decorators": [],
                               "name": "val",
-                              "optional": false
+                              "optional": false,
+                              "override": false,
+                              "readonly": false,
+                              "typeAnnotation": null
                             }
-                          ]
+                          ],
+                          "returnType": null,
+                          "thisParam": null,
+                          "typeParameters": null
                         }
                       ],
                       "callee": {
@@ -298,9 +294,7 @@
                             "type": "Identifier",
                             "start": 155,
                             "end": 160,
-                            "decorators": [],
-                            "name": "ships",
-                            "optional": false
+                            "name": "ships"
                           }
                         },
                         "optional": false,
@@ -308,12 +302,11 @@
                           "type": "Identifier",
                           "start": 161,
                           "end": 166,
-                          "decorators": [],
-                          "name": "every",
-                          "optional": false
+                          "name": "every"
                         }
                       },
-                      "optional": false
+                      "optional": false,
+                      "typeParameters": null
                     }
                   }
                 ]
@@ -322,7 +315,10 @@
               "expression": false,
               "generator": false,
               "id": null,
-              "params": []
+              "params": [],
+              "returnType": null,
+              "thisParam": null,
+              "typeParameters": null
             }
           }
         ]
@@ -333,12 +329,12 @@
         "type": "Identifier",
         "start": 59,
         "end": 64,
-        "decorators": [],
-        "name": "Board",
-        "optional": false
+        "name": "Board"
       },
-      "implements": [],
-      "superClass": null
+      "implements": null,
+      "superClass": null,
+      "superTypeParameters": null,
+      "typeParameters": null
     }
   ],
   "sourceType": "script",

It slows down a bit, but not so much?

hi-ogawa · 2025-03-17T03:23:51Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

hi-ogawa · 2025-03-17T03:42:45Z

Hmm, looking at the diff, sorting (on oxc side) doesn't seem right. Let me double check.

hi-ogawa · 2025-03-17T05:35:19Z

Merge activity

Mar 17, 1:35 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 17, 1:35 AM EDT: A user added this pull request to the Graphite merge queue.
Mar 17, 5:55 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
Mar 17, 2:01 AM EDT: A user added this pull request to the Graphite merge queue.
Mar 17, 2:02 AM EDT: A user merged this pull request with the Graphite merge queue.

#9813) Part of #9705 This doesn't magically improve passes, but it makes it easier to digest mismatch diff. <details><summary>tasks/coverage/acorn-test262-diff/typescript/tests/cases/compiler/2dArrays.diff</summary> ```diff @@ -20,12 +20,12 @@ "type": "Identifier", "start": 6, "end": 10, - "decorators": [], - "name": "Cell", - "optional": false + "name": "Cell" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null }, { "type": "ClassDeclaration", @@ -41,6 +41,7 @@ "type": "PropertyDefinition", "start": 33, "end": 49, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -49,9 +50,7 @@ "type": "Identifier", "start": 33, "end": 39, - "decorators": [], - "name": "isSunk", - "optional": false + "name": "isSunk" }, "optional": false, "override": false, @@ -77,12 +76,12 @@ "type": "Identifier", "start": 22, "end": 26, - "decorators": [], - "name": "Ship", - "optional": false + "name": "Ship" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null }, { "type": "ClassDeclaration", @@ -98,6 +97,7 @@ "type": "PropertyDefinition", "start": 71, "end": 85, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -106,9 +106,7 @@ "type": "Identifier", "start": 71, "end": 76, - "decorators": [], - "name": "ships", - "optional": false + "name": "ships" }, "optional": false, "override": false, @@ -130,10 +128,9 @@ "type": "Identifier", "start": 78, "end": 82, - "decorators": [], - "name": "Ship", - "optional": false - } + "name": "Ship" + }, + "typeParameters": null } } }, @@ -143,6 +140,7 @@ "type": "PropertyDefinition", "start": 90, "end": 104, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -151,9 +149,7 @@ "type": "Identifier", "start": 90, "end": 95, - "decorators": [], - "name": "cells", - "optional": false + "name": "cells" }, "optional": false, "override": false, @@ -175,10 +171,9 @@ "type": "Identifier", "start": 97, "end": 101, - "decorators": [], - "name": "Cell", - "optional": false - } + "name": "Cell" + }, + "typeParameters": null } } }, @@ -195,9 +190,7 @@ "type": "Identifier", "start": 118, "end": 130, - "decorators": [], - "name": "allShipsSunk", - "optional": false + "name": "allShipsSunk" }, "kind": "method", "optional": false, @@ -245,18 +238,14 @@ "type": "Identifier", "start": 191, "end": 194, - "decorators": [], - "name": "val", - "optional": false + "name": "val" }, "optional": false, "property": { "type": "Identifier", "start": 195, "end": 201, - "decorators": [], - "name": "isSunk", - "optional": false + "name": "isSunk" } } } @@ -271,11 +260,18 @@ "type": "Identifier", "start": 177, "end": 180, + "accessibility": null, "decorators": [], "name": "val", - "optional": false + "optional": false, + "override": false, + "readonly": false, + "typeAnnotation": null } - ] + ], + "returnType": null, + "thisParam": null, + "typeParameters": null } ], "callee": { @@ -298,9 +294,7 @@ "type": "Identifier", "start": 155, "end": 160, - "decorators": [], - "name": "ships", - "optional": false + "name": "ships" } }, "optional": false, @@ -308,12 +302,11 @@ "type": "Identifier", "start": 161, "end": 166, - "decorators": [], - "name": "every", - "optional": false + "name": "every" } }, - "optional": false + "optional": false, + "typeParameters": null } } ] @@ -322,7 +315,10 @@ "expression": false, "generator": false, "id": null, - "params": [] + "params": [], + "returnType": null, + "thisParam": null, + "typeParameters": null } } ] @@ -333,12 +329,12 @@ "type": "Identifier", "start": 59, "end": 64, - "decorators": [], - "name": "Board", - "optional": false + "name": "Board" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null } ], "sourceType": "script", ``` </details> It slows down a bit, but not so much?

github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Mar 17, 2025

hi-ogawa mentioned this pull request Mar 17, 2025

Align JS-side AST with standard for TypeScript #9705

Closed

hi-ogawa marked this pull request as ready for review March 17, 2025 03:36

hi-ogawa marked this pull request as draft March 17, 2025 03:42

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from d603951 to de9dd56 Compare March 17, 2025 03:52

hi-ogawa marked this pull request as ready for review March 17, 2025 03:53

hi-ogawa mentioned this pull request Mar 17, 2025

fix(parser)!: rename type_parameters to type_arguments where needed #9815

Merged

hi-ogawa added the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from e023355 to cec8b18 Compare March 17, 2025 05:35

hi-ogawa mentioned this pull request Mar 17, 2025

test(ast/estree): update acorn-test262 #9816

Merged

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from cec8b18 to 6716f9c Compare March 17, 2025 05:39

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from 6716f9c to cec8b18 Compare March 17, 2025 05:39

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from cec8b18 to 7f47991 Compare March 17, 2025 05:41

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from 7f47991 to cec8b18 Compare March 17, 2025 05:43

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from cec8b18 to e8277e8 Compare March 17, 2025 05:43

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from e8277e8 to cec8b18 Compare March 17, 2025 05:46

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from cec8b18 to 265e713 Compare March 17, 2025 05:46

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from 265e713 to cec8b18 Compare March 17, 2025 05:47

graphite-app bot force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from cec8b18 to 2a345c0 Compare March 17, 2025 05:48

hi-ogawa force-pushed the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch from 2a345c0 to ee970b1 Compare March 17, 2025 05:48

graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Mar 17, 2025

graphite-app bot merged commit ee970b1 into main Mar 17, 2025
15 checks passed

graphite-app bot deleted the 03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint branch March 17, 2025 06:02

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 17, 2025

This was referenced Mar 17, 2025

fix(ast/extree): fix Class.implements #9817

Merged

fix(ast/estree): fix BindingIdentifier #9822

Merged

fix(ast/extree): fix TSModuleDeclaration.global #9907

Merged

fix(ast/estree): fix Function.this_param #9913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

test(ast/estree): ignore field order difference from typescript-eslint#9813

test(ast/estree): ignore field order difference from typescript-eslint#9813
graphite-app[bot] merged 1 commit intomainfrom
03-17-test_ast_estree_ignore_field_order_difference_from_typescript-eslint

hi-ogawa commented Mar 17, 2025 •

edited

Loading

Uh oh!

hi-ogawa commented Mar 17, 2025 •

edited

Loading

Uh oh!

hi-ogawa commented Mar 17, 2025

Uh oh!

hi-ogawa commented Mar 17, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Comments

Conversation

hi-ogawa commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hi-ogawa commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

hi-ogawa commented Mar 17, 2025

Uh oh!

hi-ogawa commented Mar 17, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hi-ogawa commented Mar 17, 2025 •

edited

Loading

hi-ogawa commented Mar 17, 2025 •

edited

Loading

hi-ogawa commented Mar 17, 2025 •

edited by graphite-app bot

Loading