refactor(allocator): improve safety of String::from_utf8_unchecked#9772
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 14, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-cleanup
CodSpeed Performance ReportMerging #9772 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
Dunqing
approved these changes
Mar 14, 2025
…9772) Follow-on after #9656. Add a defence against potential double-free bug in `String::from_utf8_unchecked`. As noted in the comment, this is probably unnecessary, but it doesn't hurt to add this defensive code while new `Vec` implementation is under development. We can remove it again later when we're satisfied we have covered all bases.
graphite-app
bot
force-pushed
the
03-14-refactor_allocator_vec_add_comment_about_lifetime_bound_on_clonein_for_vec2_vec_
branch
from
6409205 to
a1a8b93
Compare
graphite-app
bot
force-pushed
the
03-14-refactor_allocator_improve_safety_of_string_from_utf8_unchecked_
branch
from
9ee94df to
d13817e
Compare
Member
|
You handle "unsafe" with great rigor; I am learning from you by observing closely. |
Member
Author
I am just following the greater minds of the authors of the std lib! |
Base automatically changed from
03-14-refactor_allocator_vec_add_comment_about_lifetime_bound_on_clonein_for_vec2_vec_
to
main
March 14, 2025 06:54
graphite-app
bot
deleted the
03-14-refactor_allocator_improve_safety_of_string_from_utf8_unchecked_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-on after #9656. Add a defence against potential double-free bug in
String::from_utf8_unchecked.As noted in the comment, this is probably unnecessary, but it doesn't hurt to add this defensive code while new
Vecimplementation is under development. We can remove it again later when we're satisfied we have covered all bases.