Skip to content

refactor(allocator/vec): comment out feature-gated methods#9728

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-12-refactor_allocator_vec_comment_out_feature-gated_methods
Mar 13, 2025
Merged

refactor(allocator/vec): comment out feature-gated methods#9728
graphite-app[bot] merged 1 commit intomainfrom
03-12-refactor_allocator_vec_comment_out_feature-gated_methods

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 13, 2025 •
edited
Loading

Comment out methods which are feature-gated in vec2::Vec (the implementation copied from bumpalo in #9646).

This was referenced Mar 13, 2025
Merged
Merged
@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 13, 2025 •
edited by Dunqing
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 13, 2025
Merged
Merged
Merged
Merged
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Mar 13, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 13, 2025 01:47
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9728 will not alter performance

Comparing 03-12-refactor_allocator_vec_comment_out_feature-gated_methods (6c86961) with main (0d1e2c5)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 13, 2025 •
edited
Loading

Merge activity

@overlookmotel
refactor(allocator/vec): comment out feature-gated methods (#9728)
6c86961 
Comment out methods which are feature-gated in `vec2::Vec` (the implementation copied from `bumpalo` in #9646).
@graphite-app graphite-app bot force-pushed the 03-12-refactor_allocator_vec_comment_out_feature-gated_methods branch from 47c7fe9 to 6c86961 Compare March 13, 2025 02:44
@graphite-app graphite-app bot merged commit 6c86961 into main Mar 13, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 13, 2025
@graphite-app graphite-app bot deleted the 03-12-refactor_allocator_vec_comment_out_feature-gated_methods branch March 13, 2025 02:48
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
This was referenced Mar 13, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@overlookmotel