fix(linter): import and fix tests for typescript::no_unnecessary_parameter_property_assignment#9720
Merged
Boshen merged 9 commits intooxc-project:mainfrom Mar 17, 2025
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #9720 will not alter performanceComparing Summary
|
ulrichstark
force-pushed
the
fix-no-unnecessary-parameter-property-assignment
branch
from
c3b74a5 to
094fb55
Compare
…ignment expression
ulrichstark
force-pushed
the
fix-no-unnecessary-parameter-property-assignment
branch
from
4dee3cf to
f61c9d2
Compare
Member
|
Nice work! |
shulaoda
pushed a commit
that referenced
this pull request
Mar 24, 2025
…eter_property_assignment` and fix false positive (#9973) Hey, I just added a suggested fix to the lint rule as continuation of my work in #9720 and #9618. The original typescript-eslint rule isn't capable of fixing its reported issue, but the fix should be pretty safe. I decided to configure it as `suggestion` and not as 100% safe `fix`. Also found one false positive while implementing the fix suggestion, fixed it and added a corresponding passing test.
ulrichstark
deleted the
fix-no-unnecessary-parameter-property-assignment
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #9618.
PRs for oxc/no-redundant-constructor-init: #9299 #9364
typescript-eslint rule: Docs Source Tests
Changes of this PR:
This is my first major change to OXC.
If there's anything wrong or not the OXC-way, I will happily improve on that.