Skip to content

Comments

perf(transformer/using): only do work to a static block if it has a using decl#9714

Closed
camc314 wants to merge 1 commit intographite-base/9714from
c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl
Closed

perf(transformer/using): only do work to a static block if it has a using decl#9714
camc314 wants to merge 1 commit intographite-base/9714from
c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Mar 12, 2025

No description provided.

@camc314 camc314 marked this pull request as ready for review March 12, 2025 11:35
@camc314 camc314 mentioned this pull request Mar 12, 2025
Merged
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Mar 12, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 mentioned this pull request Mar 12, 2025
Closed
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance labels Mar 12, 2025
@camc314 camc314 mentioned this pull request Mar 12, 2025
Open
8 tasks
@camc314 camc314 force-pushed the c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl branch from c3f88da to 4e1e012 Compare March 12, 2025 11:43
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 12, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9714 will create unknown performance changes

Comparing c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl (0f5c32b) with c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ (d46c902)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.2 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 294 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
🆕 minifier[antd.js] N/A 167.6 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 294.5 ms N/A
🆕 estree[checker.ts] N/A 88.4 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 88.7 µs N/A
🆕 parser[antd.js] N/A 112.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camc314 camc314 changed the base branch from c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ to graphite-base/9714 March 12, 2025 11:48
@camc314 camc314 force-pushed the graphite-base/9714 branch from 3e83008 to d46c902 Compare March 12, 2025 12:00
@camc314 camc314 force-pushed the c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl branch from 4e1e012 to 0f5c32b Compare March 12, 2025 12:00
@camc314 camc314 changed the base branch from graphite-base/9714 to c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ March 12, 2025 12:00
@camc314 camc314 changed the base branch from c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ to graphite-base/9714 March 12, 2025 12:16
@camc314 camc314 mentioned this pull request Mar 12, 2025
Closed
@camc314 camc314 changed the base branch from graphite-base/9714 to c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ March 12, 2025 12:22
@camc314 camc314 changed the base branch from c/03-12-refactor_transformer_using_move_work_to_exit_static_block_ to graphite-base/9714 March 12, 2025 12:27
@camc314 camc314 closed this Mar 18, 2025
@Dunqing Dunqing mentioned this pull request Apr 8, 2025
Closed
@Boshen Boshen deleted the c/03-12-perf_transformer_using_only_do_work_to_a_static_block_if_it_has_a_using_decl branch August 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@camc314