fix(linter): no-single-promise-in-promise-methods: do not fix Promise.all when chained#9697
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 12, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
camchenry
changed the title
CodSpeed Performance ReportMerging #9697 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
03-11-ix_linter_no-single-promise-in-promise-methods_do_not_fix_promise.all_when_chained
branch
from
9c4a058 to
a10f952
Compare
shulaoda
approved these changes
Mar 12, 2025
Contributor
Merge activity
|
….all when chained (#9697) closes #9689 aligns with the original rule behavior to not try and fix complex `Promise.all`: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/0f6048c4f66ea65caf24be40d88631daf0d0d234/rules/no-single-promise-in-promise-methods.js#L143-L145
graphite-app
bot
force-pushed
the
03-11-ix_linter_no-single-promise-in-promise-methods_do_not_fix_promise.all_when_chained
branch
from
a10f952 to
6c0978b
Compare
camc314
approved these changes
Mar 12, 2025
graphite-app
bot
deleted the
03-11-ix_linter_no-single-promise-in-promise-methods_do_not_fix_promise.all_when_chained
branch
Boshen
added a commit
that referenced
this pull request
Mar 12, 2025
## [0.15.15] - 2025-03-12 ### Features - 2ddad59 linter: Add unicorn/require-post-message-target-origin rule (#9684) (yefan) - 474a57b linter: A new multi-file analysis runtime (#9383) (branchseer) ### Bug Fixes - 6c0978b linter: No-single-promise-in-promise-methods: do not fix Promise.all when chained (#9697) (camchenry) - ab594f1 linter: Turn oxc/no-redundant-constructor-init into typescript/no-unnecessary-parameter-property-assignment (#9618) (Uli) - 91c009a linter: Add missing fail cases in `eslint-no-array-constructor` (#9659) (therewillbecode) - 2810e5b linter: Add missing fail cases in eslint/no-self-compare (#9693) (therewillbecode) ### Refactor - b9ab60b linter: Remove if let nesting from `bad-min-max-function` (#9722) (therewillbecode) - 90b0227 linter: Remove if let nesting from `eslint-operator-assignment` (#9721) (therewillbecode) - 5ef578e linter: Improve `jest/no-alias-methods` (#9694) (therewillbecode) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9689
aligns with the original rule behavior to not try and fix complex
Promise.all: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/0f6048c4f66ea65caf24be40d88631daf0d0d234/rules/no-single-promise-in-promise-methods.js#L143-L145