Skip to content

Comments

docs(transformer/module_runner): reformat module doc comment#9687

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-11-docs_transformer_module_runner_reformat_module_doc_comment
Mar 11, 2025
Merged

docs(transformer/module_runner): reformat module doc comment#9687
graphite-app[bot] merged 1 commit intomainfrom
03-11-docs_transformer_module_runner_reformat_module_doc_comment

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Mar 11, 2025 •
edited
Loading

Doc comment for module use //!, rather than ///.

@overlookmotel Graphite App
Copy link
Member Author

overlookmotel commented Mar 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel mentioned this pull request Mar 11, 2025
Merged
@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-docs Category - Documentation. Related to user-facing or internal documentation labels Mar 11, 2025
@overlookmotel overlookmotel marked this pull request as ready for review March 11, 2025 11:19
@overlookmotel overlookmotel requested a review from Dunqing as a code owner March 11, 2025 11:19
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9687 will create unknown performance changes

Comparing 03-11-docs_transformer_module_runner_reformat_module_doc_comment (3ccb2fa) with main (31d626b)

Summary

🆕 39 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 parser_napi[RadixUIAdoptionSection.jsx] N/A 4.8 ms N/A
🆕 parser_napi[pdf.mjs] N/A 1.8 s N/A
🆕 parser_napi_raw[RadixUIAdoptionSection.jsx] N/A 1.3 ms N/A
🆕 parser_napi_raw[cal.com.tsx] N/A 699.9 ms N/A
🆕 parser_napi_raw[checker.ts] N/A 1.1 s N/A
🆕 parser_napi_raw[pdf.mjs] N/A 266.2 ms N/A
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.1 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.7 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 294.9 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Dunqing
Dunqing approved these changes Mar 11, 2025
View reviewed changes
Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I made a mistake

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@Dunqing Graphite App
Copy link
Member

Dunqing commented Mar 11, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 11, 8:02 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 11, 8:02 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 11, 8:11 AM EDT: A user merged this pull request with the Graphite merge queue.

@overlookmotel
docs(transformer/module_runner): reformat module doc comment (#9687)
3ccb2fa 
Doc comment for module use `//!`, rather than `///`.
@graphite-app graphite-app bot force-pushed the 03-11-perf_transformer_module_runner_use_itoa_to_convert_u32_to_string branch from 9448d2a to 31d626b Compare March 11, 2025 12:02
@graphite-app graphite-app bot force-pushed the 03-11-docs_transformer_module_runner_reformat_module_doc_comment branch from 32537bf to 3ccb2fa Compare March 11, 2025 12:03
Base automatically changed from 03-11-perf_transformer_module_runner_use_itoa_to_convert_u32_to_string to main March 11, 2025 12:07
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 11, 2025
@graphite-app graphite-app bot merged commit 3ccb2fa into main Mar 11, 2025
33 checks passed
@graphite-app graphite-app bot deleted the 03-11-docs_transformer_module_runner_reformat_module_doc_comment branch March 11, 2025 12:11
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Dunqing approved these changes

Assignees

No one assigned

Labels

A-transformer Area - Transformer / Transpiler C-docs Category - Documentation. Related to user-facing or internal documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overlookmotel @Dunqing