fix(parser)!: parse TS import attributes options as object expression#9662
Closed
ArnaudBarre wants to merge 1 commit intooxc-project:mainfrom
ArnaudBarre:ts-import-type-options
Closed
fix(parser)!: parse TS import attributes options as object expression#9662ArnaudBarre wants to merge 1 commit intooxc-project:mainfrom ArnaudBarre:ts-import-type-options
ArnaudBarre wants to merge 1 commit intooxc-project:mainfrom
ArnaudBarre:ts-import-type-options
Conversation
github-actions
bot
added
A-parser
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Boshen
reviewed
Mar 11, 2025
| /editors/vscode/out/ | ||
| /editors/vscode/*.vsix | ||
|
|
||
| # JetBrains |
Contributor
Author
There was a problem hiding this comment.
The issue is that I don't want to ignore it on my repos
But I will use a local gitignore
Member
|
Our AST is more strict and easier to work with, let's serialize this node as |
Member
|
As it turns out |
Member
|
I'll fix this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS-ESLint spec: https://github.com/typescript-eslint/typescript-eslint/blob/9aa0b6b49807599b1c2b704b778df74c91084a7c/packages/ast-spec/src/type/TSImportType/spec.ts#L8
ast-explorer: https://ast-explorer.dev/#eNoty8EKQiEQheFXGc6q4PYCQoteotVsRIy8eB1xhiLEd0+p7XfO35HhsPuX19BSNWyoE+xT4w8uUXMqy8Pf6UZXSkeVZifGQ4SxUX8nezrq6+CIsasUxhjnGcoMOxeaHMPh77FpWuv6ZW9RjcFlYHwB6tsulA==
I'm block by the fact that
parse_object_expressionreturn an expression and not an objectExpressionFeel free to close another PR