Skip to content

feat(allocator): add Vec2#9646

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-10-feat_allocator_add_vec2
Mar 12, 2025
Merged

feat(allocator): add Vec2#9646
graphite-app[bot] merged 1 commit intomainfrom
03-10-feat_allocator_add_vec2

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 10, 2025 •
edited
Loading

related: #9706

These two files are copied from Bumplo's vec and raw_vec, they will be used to replace allocator_api2's Vec later PRs.

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Mar 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing mentioned this pull request Mar 10, 2025
Merged
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Mar 10, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9646 will not alter performance

Comparing 03-10-feat_allocator_add_vec2 (3d4400c) with main (f9580d8)

Summary

✅ 32 untouched benchmarks
🆕 1 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[checker.ts] N/A 3 s N/A

Boshen
Boshen reviewed Mar 10, 2025
View reviewed changes
This was referenced Mar 10, 2025
Merged
Merged
Merged
@Dunqing Dunqing force-pushed the 03-10-feat_allocator_add_vec2 branch from f328de5 to 7d8ee88 Compare March 11, 2025 10:26
@Dunqing Dunqing marked this pull request as ready for review March 11, 2025 10:28
@Dunqing Dunqing requested a review from overlookmotel March 11, 2025 10:49
@overlookmotel overlookmotel mentioned this pull request Mar 12, 2025
Closed
overlookmotel
overlookmotel approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double-checked these 2 files are copied completely verbatim from bumpalo. Only differences are the addition of comments at top of files saying where the code was copied from, and running rustfmt on them.

Merging just this one for now. Would like to look into why lifetime changes are required in #9656 before merging the rest of the stack.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
@overlookmotel Graphite App
Copy link
Member

overlookmotel commented Mar 12, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 12, 4:52 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 4:52 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 12, 4:57 AM EDT: A user merged this pull request with the Graphite merge queue.

@Dunqing
feat(allocator): add Vec2 (#9646)
3d4400c 
related: #9706

These two files are copied from Bumplo's `vec` and `raw_vec`, they will be used to replace allocator_api2's `Vec` later PRs.
@graphite-app graphite-app bot force-pushed the 03-10-feat_allocator_add_vec2 branch from 7d8ee88 to 3d4400c Compare March 12, 2025 08:52
@graphite-app graphite-app bot merged commit 3d4400c into main Mar 12, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 03-10-feat_allocator_add_vec2 branch March 12, 2025 08:57
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
This was referenced Mar 13, 2025
Merged
Merged
Merged
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2025
@overlookmotel
refactor(allocator/vec): comment out feature-gated methods (#9728)
6c86961 
Comment out methods which are feature-gated in `vec2::Vec` (the implementation copied from `bumpalo` in #9646).
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2025
@overlookmotel
docs(allocator/vec): fix link in doc comment for Vec2 (#9729)
daf7a1e 
Fix a doc comment on a method of `vec2::Vec` (the implementation copied from `bumpalo` in #9646).
graphite-app bot pushed a commit that referenced this pull request Mar 13, 2025
@overlookmotel
refactor(allocator/vec): disable lint warnings in vec2 files (#9730)
5c5e010 
Disable lint warnings for `vec2::Vec` (the implementation copied from `bumpalo` in #9646).
@oxc-bot oxc-bot mentioned this pull request Mar 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Boshen Boshen Boshen left review comments

@overlookmotel overlookmotel overlookmotel approved these changes

Assignees

@overlookmotel overlookmotel

Labels

C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dunqing @overlookmotel @Boshen