Skip to content

Comments

refactor(linter): improve eslint/no-duplicate-imports#9627

Merged
Boshen merged 4 commits intooxc-project:mainfrom
therewillbecode:refactor/no-duplicate-imports
Mar 10, 2025
Merged

refactor(linter): improve eslint/no-duplicate-imports#9627
Boshen merged 4 commits intooxc-project:mainfrom
therewillbecode:refactor/no-duplicate-imports

Conversation

@therewillbecode
Copy link
Contributor

@therewillbecode therewillbecode commented Mar 9, 2025

  • Refactor some nested if lets into let else to avoid unneeded nesting.
  • Add missing docs for the includeExports option. I expanded on the Eslint docs for this option. Relates to Improve linter rules documentation #6050

Rule details: https://eslint.org/docs/latest/rules/no-duplicate-imports

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 9, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #9627 will not alter performance

Comparing therewillbecode:refactor/no-duplicate-imports (5850916) with main (b0d979d)

Summary

✅ 39 untouched benchmarks

@therewillbecode
Copy link
Contributor Author

Interesting the codspeed benchmark says will create unknown performance changes. Does that mean that codspeed hasn't managed to assess the performance impact?

@Boshen
Copy link
Member

Boshen commented Mar 9, 2025

Interesting the codspeed benchmark says will create unknown performance changes. Does that mean that codspeed hasn't managed to assess the performance impact?

No ... it's a codspeed bug, it's not picking up data from main branch, which is still running when this PR finished benchmarking.

@Boshen Boshen merged commit c174600 into oxc-project:main Mar 10, 2025
32 checks passed
@therewillbecode therewillbecode deleted the refactor/no-duplicate-imports branch March 11, 2025 07:22
Boshen added a commit that referenced this pull request Mar 11, 2025
## [0.15.14] - 2025-03-11

### Features

- 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode)
- ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric
DIRAND)
- 50327f3 linter: Add import/exports-last (#9578) (yefan)
- 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481)
(yefan)
- 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode)
- 41f32ea linter: Allow adding more overrides via `extends` configs
(#9475) (camchenry)
- fb7cf10 linter: Allowing `plugins` to be extended with `extends`
(#9473) (camchenry)
- fc74849 linter: Inherit `rules` via the extended config files (#9308)
(camchenry)
- 3fce826 linter: Add support for `extends` property in oxlintrc (#9217)
(camchenry)

### Bug Fixes

- 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632)
(therewillbecode)
- a9d7df9 linter: False positive in `unicorn/escape-case` (#9638)
(shulaoda)
- 3831819 linter: Fix example lint declaration and macro syntax (#9626)
(Uli)
- 4ca62ab linter: Output right file line and column for `.vue`, `.astro`
and `.svelte` files (#9484) (Sysix)
- 3105159 linter: Do not output number of rules with nested configs
(#9476) (camchenry)
- 5ecda01 linter: Support nested extending (#9472) (camchenry)

### Documentation

- b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658)
(therewillbecode)
- 1cc43f7 linter: Improve the documentation of `eslint-no-console`
(#9612) (therewillbecode)
- 608bb77 linter: Improve the docs and add test case for
`typescript-no-extra-non-null-assertion` (#9609) (therewillbecode)
- 43add5d linter: Better docs for
`typescript-no-non-null-asserted-nullish-coalescing` rule (#9610)
(therewillbecode)
- bd90ce6 linter: Improve the docs and add test cases for
`eslint-no-shadow-restricted-names` (#9597) (therewillbecode)
- a0c9f7c linter: Improve the documentation of `eslint-no-func-assign`
(#9596) (therewillbecode)
- ec922e9 linter: Improve the documentation of
`typescript-consistent-type-definitions` (#9575) (therewillbecode)
- 165c89d linter: Improve the documentation of `typescript-no-namespace`
(#9545) (therewillbecode)

### Refactor

- c174600 linter: Improve `eslint/no-duplicate-imports` (#9627)
(therewillbecode)
- 31ba425 linter: Improve `eslint/no-self-assign` (#9635)
(therewillbecode)
- 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen)
- be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda)
- b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda)
- 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode)
- 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen)

### Testing

- 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants