Skip to content

Comments

test(linter): remove test dependency on oxlint#9513

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-03-test_linter_remove_test_dependency_on_oxlint
Mar 4, 2025
Merged

test(linter): remove test dependency on oxlint#9513
graphite-app[bot] merged 1 commit intomainfrom
03-03-test_linter_remove_test_dependency_on_oxlint

Conversation

@camchenry
Copy link
Member

@camchenry camchenry commented Mar 3, 2025

Moves test fixtures around so that oxc_linter doesn't need to depend on test fixtures in oxlint.

Copy link
Member Author

camchenry commented Mar 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #9513 will create unknown performance changes

Comparing 03-03-test_linter_remove_test_dependency_on_oxlint (934a387) with main (3105159)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 23.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 66.1 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 57.9 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.7 ms N/A
🆕 lexer[checker.ts] N/A 14.5 ms N/A
🆕 lexer[pdf.mjs] N/A 3.8 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 297.9 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
🆕 minifier[antd.js] N/A 163 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 285.8 ms N/A
🆕 estree[checker.ts] N/A 91.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 89 µs N/A
🆕 parser[antd.js] N/A 111.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@camchenry camchenry force-pushed the 03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs branch 3 times, most recently from ba2fbe3 to e0406ff Compare March 4, 2025 03:48
@camchenry camchenry force-pushed the 03-03-test_linter_remove_test_dependency_on_oxlint branch from 050ad34 to 029e919 Compare March 4, 2025 03:49
@camchenry camchenry marked this pull request as ready for review March 4, 2025 03:49
@camchenry camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025
Copy link
Member Author

camchenry commented Mar 4, 2025

Merge activity

  • Mar 3, 10:54 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 3, 11:00 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 3, 11:12 PM EST: A user merged this pull request with the Graphite merge queue.

@camchenry camchenry force-pushed the 03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs branch from e0406ff to 54f935b Compare March 4, 2025 04:04
@camchenry camchenry force-pushed the 03-03-test_linter_remove_test_dependency_on_oxlint branch from 029e919 to f6af1b8 Compare March 4, 2025 04:04
Moves test fixtures around so that `oxc_linter` doesn't need to depend on test fixtures in `oxlint`.
@graphite-app graphite-app bot force-pushed the 03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs branch from 54f935b to 3105159 Compare March 4, 2025 04:04
@graphite-app graphite-app bot force-pushed the 03-03-test_linter_remove_test_dependency_on_oxlint branch from f6af1b8 to 934a387 Compare March 4, 2025 04:05
Base automatically changed from 03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs to main March 4, 2025 04:10
@graphite-app graphite-app bot merged commit 934a387 into main Mar 4, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 03-03-test_linter_remove_test_dependency_on_oxlint branch March 4, 2025 04:12
Boshen added a commit that referenced this pull request Mar 11, 2025
## [0.15.14] - 2025-03-11

### Features

- 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode)
- ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric
DIRAND)
- 50327f3 linter: Add import/exports-last (#9578) (yefan)
- 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481)
(yefan)
- 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode)
- 41f32ea linter: Allow adding more overrides via `extends` configs
(#9475) (camchenry)
- fb7cf10 linter: Allowing `plugins` to be extended with `extends`
(#9473) (camchenry)
- fc74849 linter: Inherit `rules` via the extended config files (#9308)
(camchenry)
- 3fce826 linter: Add support for `extends` property in oxlintrc (#9217)
(camchenry)

### Bug Fixes

- 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632)
(therewillbecode)
- a9d7df9 linter: False positive in `unicorn/escape-case` (#9638)
(shulaoda)
- 3831819 linter: Fix example lint declaration and macro syntax (#9626)
(Uli)
- 4ca62ab linter: Output right file line and column for `.vue`, `.astro`
and `.svelte` files (#9484) (Sysix)
- 3105159 linter: Do not output number of rules with nested configs
(#9476) (camchenry)
- 5ecda01 linter: Support nested extending (#9472) (camchenry)

### Documentation

- b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658)
(therewillbecode)
- 1cc43f7 linter: Improve the documentation of `eslint-no-console`
(#9612) (therewillbecode)
- 608bb77 linter: Improve the docs and add test case for
`typescript-no-extra-non-null-assertion` (#9609) (therewillbecode)
- 43add5d linter: Better docs for
`typescript-no-non-null-asserted-nullish-coalescing` rule (#9610)
(therewillbecode)
- bd90ce6 linter: Improve the docs and add test cases for
`eslint-no-shadow-restricted-names` (#9597) (therewillbecode)
- a0c9f7c linter: Improve the documentation of `eslint-no-func-assign`
(#9596) (therewillbecode)
- ec922e9 linter: Improve the documentation of
`typescript-consistent-type-definitions` (#9575) (therewillbecode)
- 165c89d linter: Improve the documentation of `typescript-no-namespace`
(#9545) (therewillbecode)

### Refactor

- c174600 linter: Improve `eslint/no-duplicate-imports` (#9627)
(therewillbecode)
- 31ba425 linter: Improve `eslint/no-self-assign` (#9635)
(therewillbecode)
- 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen)
- be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda)
- b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda)
- 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode)
- 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen)

### Testing

- 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-cli Area - CLI A-linter Area - Linter C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant