fix(linter): do not output number of rules with nested configs#9476
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 4, 2025
Conversation
github-actions
bot
added
A-linter
This was referenced Mar 1, 2025
Member
Author
camchenry
force-pushed
the
03-01-feat_linter_allow_adding_more_overrides_via_extends_configs
branch
from
46b5f2f to
c649380
Compare
camchenry
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
16c9723 to
0c02de8
Compare
CodSpeed Performance ReportMerging #9476 will create unknown performance changesComparing Summary
Benchmarks breakdown
|
shulaoda
reviewed
Mar 2, 2025
shulaoda
approved these changes
Mar 2, 2025
Sysix
approved these changes
Mar 2, 2025
Member
There was a problem hiding this comment.
The number of rules is already not the exact representation of used rules.
Remapped rules are not count as separate ones and probably the count for overrides is ignored.
It is part of the discussion: #9421
I am thinking about removing this information in general
camchenry
force-pushed
the
03-01-feat_linter_allow_adding_more_overrides_via_extends_configs
branch
2 times, most recently
from
e0899c3 to
bf63a27
Compare
camchenry
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
0c02de8 to
b00df65
Compare
camchenry
force-pushed
the
03-01-feat_linter_allow_adding_more_overrides_via_extends_configs
branch
from
bf63a27 to
489e3d3
Compare
camchenry
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
b00df65 to
ba2fbe3
Compare
camchenry
force-pushed
the
03-01-feat_linter_allow_adding_more_overrides_via_extends_configs
branch
from
489e3d3 to
0e5a0de
Compare
camchenry
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
ba2fbe3 to
e0406ff
Compare
Member
Author
Merge activity
|
camchenry
changed the base branch from
03-01-feat_linter_allow_adding_more_overrides_via_extends_configs
to
graphite-base/9476
camchenry
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
e0406ff to
54f935b
Compare
This is a small output update to fix some noisy snapshot tests that output the number of rules. When using nested configs, outputting the number of rules is not helpful I think since it varies from file to file, but open to feedback on this.
graphite-app
bot
force-pushed
the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
from
54f935b to
3105159
Compare
graphite-app
bot
deleted the
03-01-fix_linter_do_not_output_number_of_rules_with_nested_configs
branch
Boshen
added a commit
that referenced
this pull request
Mar 11, 2025
## [0.15.14] - 2025-03-11 ### Features - 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode) - ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric DIRAND) - 50327f3 linter: Add import/exports-last (#9578) (yefan) - 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481) (yefan) - 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode) - 41f32ea linter: Allow adding more overrides via `extends` configs (#9475) (camchenry) - fb7cf10 linter: Allowing `plugins` to be extended with `extends` (#9473) (camchenry) - fc74849 linter: Inherit `rules` via the extended config files (#9308) (camchenry) - 3fce826 linter: Add support for `extends` property in oxlintrc (#9217) (camchenry) ### Bug Fixes - 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632) (therewillbecode) - a9d7df9 linter: False positive in `unicorn/escape-case` (#9638) (shulaoda) - 3831819 linter: Fix example lint declaration and macro syntax (#9626) (Uli) - 4ca62ab linter: Output right file line and column for `.vue`, `.astro` and `.svelte` files (#9484) (Sysix) - 3105159 linter: Do not output number of rules with nested configs (#9476) (camchenry) - 5ecda01 linter: Support nested extending (#9472) (camchenry) ### Documentation - b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658) (therewillbecode) - 1cc43f7 linter: Improve the documentation of `eslint-no-console` (#9612) (therewillbecode) - 608bb77 linter: Improve the docs and add test case for `typescript-no-extra-non-null-assertion` (#9609) (therewillbecode) - 43add5d linter: Better docs for `typescript-no-non-null-asserted-nullish-coalescing` rule (#9610) (therewillbecode) - bd90ce6 linter: Improve the docs and add test cases for `eslint-no-shadow-restricted-names` (#9597) (therewillbecode) - a0c9f7c linter: Improve the documentation of `eslint-no-func-assign` (#9596) (therewillbecode) - ec922e9 linter: Improve the documentation of `typescript-consistent-type-definitions` (#9575) (therewillbecode) - 165c89d linter: Improve the documentation of `typescript-no-namespace` (#9545) (therewillbecode) ### Refactor - c174600 linter: Improve `eslint/no-duplicate-imports` (#9627) (therewillbecode) - 31ba425 linter: Improve `eslint/no-self-assign` (#9635) (therewillbecode) - 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen) - be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda) - b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda) - 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode) - 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen) ### Testing - 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small output update to fix some noisy snapshot tests that output the number of rules. When using nested configs, outputting the number of rules is not helpful I think since it varies from file to file, but open to feedback on this.