Skip to content

Comments

feat(ast_tools): record visibility of structs and enums in Schema#9450

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_
Feb 28, 2025
Merged

feat(ast_tools): record visibility of structs and enums in Schema#9450
graphite-app[bot] merged 1 commit intomainfrom
02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 28, 2025

Add visibility field to StructDef and EnumDef, recording whether types are pub, pub(crate), or private.

Copy link
Member Author

overlookmotel commented Feb 28, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Feb 28, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 28, 2025 18:29
@github-actions github-actions bot added the A-ast Area - AST label Feb 28, 2025
@overlookmotel overlookmotel force-pushed the 02-28-feat_ast_tools_generate_field_offset_assertions_for_more_types branch from 3cd0850 to 4f5d4e7 Compare February 28, 2025 18:31
@overlookmotel overlookmotel force-pushed the 02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_ branch from af32494 to 0128ca8 Compare February 28, 2025 18:31
@overlookmotel
Copy link
Member Author

None of this stack affects runtime code, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 28, 2025
Copy link
Member Author

overlookmotel commented Feb 28, 2025

Merge activity

  • Feb 28, 1:37 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 28, 1:43 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 28, 1:56 PM EST: A user merged this pull request with the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 28, 2025

CodSpeed Performance Report

Merging #9450 will not alter performance

Comparing 02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_ (af32494) with 02-28-feat_ast_tools_generate_field_offset_assertions_for_more_types (4f5d4e7)

Summary

✅ 33 untouched benchmarks

…9450)

Add `visibility` field to `StructDef` and `EnumDef`, recording whether types are `pub`, `pub(crate)`, or private.
@graphite-app graphite-app bot force-pushed the 02-28-feat_ast_tools_generate_field_offset_assertions_for_more_types branch from 4f5d4e7 to a9f0d2b Compare February 28, 2025 18:46
@graphite-app graphite-app bot requested a review from leaysgur as a code owner February 28, 2025 18:46
@graphite-app graphite-app bot force-pushed the 02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_ branch from 0128ca8 to d19e4ea Compare February 28, 2025 18:46
Base automatically changed from 02-28-feat_ast_tools_generate_field_offset_assertions_for_more_types to main February 28, 2025 18:53
@graphite-app graphite-app bot merged commit d19e4ea into main Feb 28, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-28-feat_ast_tools_record_visibility_of_structs_and_enums_in_schema_ branch February 28, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant