perf(isolated_declarations): reduce looping over statements#9393
Closed
overlookmotel wants to merge 1 commit intomainfrom
Closed
perf(isolated_declarations): reduce looping over statements#9393overlookmotel wants to merge 1 commit intomainfrom
overlookmotel wants to merge 1 commit intomainfrom
Conversation
github-actions
bot
added
A-isolated-declarations
This was referenced Feb 26, 2025
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9393 will not alter performanceComparing Summary
|
Member
Author
|
Ha! Perf actually regresses a little. I'll have to look deeper. |
Boshen
changed the base branch from
02-23-refactor_isolated_declarations_rename_var
to
graphite-base/9393
Boshen
force-pushed
the
graphite-base/9393
branch
from
e4c1977 to
c880481
Compare
Boshen
force-pushed
the
02-23-perf_isolated_declarations_reduce_looping_over_statements
branch
from
5a7d54e to
6836790
Compare
Boshen
force-pushed
the
02-23-perf_isolated_declarations_reduce_looping_over_statements
branch
from
6836790 to
df75980
Compare
overlookmotel
force-pushed
the
02-23-perf_isolated_declarations_reduce_looping_over_statements
branch
from
df75980 to
bc98ad0
Compare
overlookmotel
force-pushed
the
02-23-perf_isolated_declarations_reduce_looping_over_statements
branch
from
bc98ad0 to
eca808a
Compare
Member
Author
|
Now not negative perf effect, but not positive either. Never mind... |
overlookmotel
deleted the
02-23-perf_isolated_declarations_reduce_looping_over_statements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce number of loops over
Program's statements.transform_program_without_module_declarationconstructed a temporaryVecand then iterated over it to generate the finalVec. Cut out the intermediateVec.transform_statements_on_demandcreated aVecand then calledretainon it to filter it down. Combine theVecconstruction and filtering into a single loop.The gain from (1) is larger, but only (2) will show up in our benchmark as it takes the
transform_statements_on_demandpath.