Skip to content

Comments

feat(parser): support V8 intrinsics#9379

Merged
Boshen merged 1 commit intooxc-project:mainfrom
srijan-paul:support-v8-intrinsics
Mar 2, 2025
Merged

feat(parser): support V8 intrinsics#9379
Boshen merged 1 commit intooxc-project:mainfrom
srijan-paul:support-v8-intrinsics

Conversation

@srijan-paul
Copy link
Contributor

@srijan-paul srijan-paul commented Feb 26, 2025

V8 has custom syntax for runtime calls, commonly called "intrinsics".
This PR implements support for this across the toolchain.

@srijan-paul srijan-paul marked this pull request as draft February 26, 2025 10:37
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 26, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request A-prettier labels Feb 26, 2025
@github-actions github-actions bot added A-codegen Area - Code Generation A-linter Area - Linter labels Feb 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 26, 2025

CodSpeed Performance Report

Merging #9379 will create unknown performance changes

Comparing srijan-paul:support-v8-intrinsics (5d8eed1) with main (ec2193e)

Summary

🆕 33 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 25 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 68.1 ms N/A
🆕 isolated-declarations[vue-id.ts] N/A 57.3 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 20.8 µs N/A
🆕 lexer[antd.js] N/A 22.8 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.6 ms N/A
🆕 lexer[checker.ts] N/A 13.7 ms N/A
🆕 lexer[pdf.mjs] N/A 3.7 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.7 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 2.9 s N/A
🆕 mangler[antd.js] N/A 16.1 ms N/A
🆕 mangler[react.development.js] N/A 298.1 µs N/A
🆕 mangler[typescript.js] N/A 39.8 ms N/A
🆕 minifier[antd.js] N/A 162.3 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 284.1 ms N/A
🆕 estree[checker.ts] N/A 91.8 ms N/A
🆕 parser[RadixUIAdoptionSection.jsx] N/A 88 µs N/A
🆕 parser[antd.js] N/A 109.1 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@leaysgur
Copy link
Member

@srijan-paul
Copy link
Contributor Author

srijan-paul commented Feb 26, 2025

@leaysgur That's right! I was going for something closer to what V8 itself does.

Does OXC want to run Babel's V8 intrinsic test fixtures? If so, then I can add a V8IntrinsicIdentifier node instead.

However I feel we can do slightly better than Babel. Intrinsics are always runtime calls, meaning that intrinsic identifiers on their own don't occur anywhere else (see this playground example), and the runtime calls have stricter syntax rules than other CallExpressions – for instance, an argument can't be a SpreadElement. We can enforce both invariants in the type system if we keep V8IntrinsicExpression a different node type. What do you think?

cc: @overlookmotel

@Boshen
Copy link
Member

Boshen commented Feb 27, 2025

Closer to v8 so that Nova can implement its own debugging APIs, which was our original intention of adding this.

@github-actions github-actions bot added the A-parser Area - Parser label Feb 27, 2025
@srijan-paul srijan-paul force-pushed the support-v8-intrinsics branch from 9b85897 to 6252c2f Compare February 27, 2025 19:44
@srijan-paul srijan-paul marked this pull request as ready for review February 27, 2025 20:03
@Boshen Boshen changed the title feat(parser): support V8 intrinsics feat(parser)!: support V8 intrinsics Feb 28, 2025
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A parser option and a few codegen tests should be added.

@leaysgur
Copy link
Member

As for the oxc_prettier related code, there are a few things that want to confirm & fix, but OK, I'll deal with them later. 🙆🏻

You may need to run cargo run -p oxc_prettier_conformance to update the snapshot.

@srijan-paul srijan-paul changed the title feat(parser)!: support V8 intrinsics feat(parser): support V8 intrinsics Feb 28, 2025
@Boshen Boshen force-pushed the support-v8-intrinsics branch from 248a572 to 5d8eed1 Compare March 1, 2025 13:22
@Boshen Boshen merged commit 2a08b14 into oxc-project:main Mar 2, 2025
27 checks passed
Boshen added a commit that referenced this pull request Mar 4, 2025
## [0.54.0] - 2025-03-04

- 098f652 codegen: [**BREAKING**] Add `CommentAnnotation` to avoid
parsing comments again (#9506) (Boshen)

- a8d1d48 parser,codegen: [**BREAKING**] Parse and
print`#__NO_SIDE_EFFECTS__` (#9496) (Boshen)

- 355a4db napi/parser: [**BREAKING**] Remove `parse_without_return` API
(#9455) (Boshen)

- a5cde10 visit_ast: [**BREAKING**] Add `oxc_visit_ast` crate (#9428)
(Boshen)

- abb15e0 ast: [**BREAKING**] Add `pure` field to `Function`,
`CallExpression`, and `NewExpression` (#9207) (overlookmotel)

### Features

- a9f0d2b ast_tools: Generate field offset assertions for more types
(#9449) (overlookmotel)
- 64f4a82 ecmascript: Handle pure call expression in chain expressions
(#9480) (sapphi-red)
- 32139d2 ecmascript: Support `/* @__PURE__ */` in may_have_side_effects
(#9409) (sapphi-red)
- f5453f6 minifier: Flatten spread args in new expressions (#9512)
(sapphi-red)
- f8073f3 minifier: Support if with side effects in dead code
elimination (#9502) (sapphi-red)
- 10eb8f7 minifier: Use `remove_unused_expression` in
`try_fold_sequence_expression` in `remove_dead_code` (#9467)
(sapphi-red)
- 70916db minifier: Remove unused expression in for init and update
(#9466) (sapphi-red)
- 26fde56 minifier: Inline simple IIFEs in `remove_unused_expression`
(#9465) (sapphi-red)
- ec2193e minifier: Support extracting arguments in pure calls in
`remove_unused_expression` (#9463) (sapphi-red)
- 007051c minifier: Compress `a != null && a.b()` to `a?.b()` in
`remove_unused_expression` (#9459) (sapphi-red)
- 50fce20 minifier: Support binary expression in
`remove_unused_expression` (#9456) (sapphi-red)
- ed9ede3 minifier: Support conditional expression in
`remove_unused_expression` (#9432) (sapphi-red)
- 3520538 minifier: Support object expression in
`remove_unused_expression` (#9430) (sapphi-red)
- fb8a93d minifier: Improve array expression handling in
`remove_unused_expression` (#9427) (sapphi-red)
- ff477cd minifier: Support template literals in
`remove_unused_expression` (#9426) (sapphi-red)
- 0d26113 minifier: Compress `/* @__PURE__ */ a() ? b : b` to `b`
(#9410) (sapphi-red)
- 68c77c8 napi/parser: Return semantic errors (#9460) (Boshen)
- 7d7f16c parser: Apply pure to rhs of binary expression (#9492)
(Boshen)
- 2a08b14 parser: Support V8 intrinsics (#9379) (injuly)
- 9b7017c parser,codegen: Pure annotations (#9351) (Boshen)
- aa06932 transformer: Support `ModuleRunnerTransform` (#9371) (Dunqing)

### Bug Fixes

- 75f06ad codegen: Do not print comments when only `annotation_comments`
is enabled (#9518) (Dunqing)
- f5bbd5d ecmascript: Fix toString for negative numbers (#9508)
(sapphi-red)
- d2cd975 ecmascript: Fix may_have_side_effects for `${a() === b}`
(#9478) (sapphi-red)
- 584d847 ecmascript: Objects passed to template literals may have side
effects (#9425) (sapphi-red)
- b371fdc estree/ast: Camel-case `typeAnnotation` field (#9420)
(overlookmotel)
- 1fff993 minifier: Correctly remove dead code in `try` with `finally`
(#9503) (sapphi-red)
- 0b96ebe minifier: Don't inline IIFE with parameters (#9477)
(sapphi-red)
- 071c84c minifier: Skip `try_fold_stmt_in_boolean_context` on
`ExpressionStatement` (#9458) (sapphi-red)
- 306284d minifier: Call mark_current_function_as_changed in
remove_unused_expression (#9457) (sapphi-red)
- 9c6ae9f parser: `@__NO_SIDE_EFFECTS` only affects const variable decl
(#9517) (Boshen)
- b7d5513 parser: Parse `@__NO_SIDE_EFFECTS__` between `export default`
and `async function` (#9514) (Boshen)
- 01de74c parser: Correctly fail parsing when parsing `foo.bar?.`
(#9499) (camc314)
- 58defe3 parser: Mark expression as pure in chain expression (#9479)
(sapphi-red)
- 2a03689 parser: Mark expressions on the left side of logical and
conditional expressions as pure (#9414) (sapphi-red)
- 7fde233 transformer/legacy-decorator: Incorrect check for potentially
non-existent ident (#9491) (Dunqing)
- b4f050c transformer/legacy-decorator: Metadata incorrectly wrapped by
decorateParam (#9490) (Dunqing)
- 5f67fa9 transformer/optional-chaning: Keep `this` when transforming
`this.f?.()` (#9505) (camc314)

### Performance

- 10e4431 ast/estree: Skip escaping identifiers (#9398) (overlookmotel)
- b0a0a82 ast/estree: Reduce overhead serializing static strings (#9396)
(overlookmotel)
- 27a8e50 isolated_declarations: Reserve sufficient capacity in
statements `Vec` (#9394) (overlookmotel)

### Refactor

- 8916335 ast/estree: Convert enums with converters on variants (#9438)
(overlookmotel)
- dcff40c ast_tools: Generate layout assertions in multiple crates
(#9448) (overlookmotel)
- 19c4835 codegen: Simplify printing comments between arguments in
call-like expressions (#9501) (Dunqing)
- c880481 isolated_declarations: Rename var (#9390) (overlookmotel)
- 37e41f0 isolated_declarations: Use aliases `ArenaBox` / `ArenaVec`
(#9389) (overlookmotel)
- bbb450c minifier: Move `a != null && b` -> `a ?? b` compression to
`remove_unused_expression` (#9468) (sapphi-red)
- b93774c minifier: Move `try_fold_iife` to `remove_unused_expression`
(#9464) (sapphi-red)
- 96a9719 minifier: Use `may_have_side_effects` in
`remove_unused_expression` (#9413) (sapphi-red)

### Testing

- c187b11 ecmascript: Add comments and tests for cases where
`ToPropertyKey` throws an error (#9429) (sapphi-red)
- d129055 napi: Add tests for worker threads (#9408) (Boshen)
- 48d51e3 napi: Add tests for `hashbang` field (#9386) (overlookmotel)

Co-authored-by: Boshen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-codegen Area - Code Generation A-linter Area - Linter A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants