feat(linter): support allowable method diagnostic for eslint/no-console#9350
Closed
ityuany wants to merge 6 commits intooxc-project:mainfrom
sheinsight:pretty-log
Closed
feat(linter): support allowable method diagnostic for eslint/no-console#9350ityuany wants to merge 6 commits intooxc-project:mainfrom sheinsight:pretty-log
eslint/no-console#9350ityuany wants to merge 6 commits intooxc-project:mainfrom
sheinsight:pretty-log
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #9350 will not alter performanceComparing Summary
|
shulaoda
changed the title
eslint/no-console
shulaoda
reviewed
Feb 25, 2025
… configuration - Modified `no_console_diagnostic` function to add a list of allowed methods argument - Include the list of allowed console methods in the prompt message. - Updated diagnostic calls to support passing information about allowed methods.
…rules Refactored warning message construction logic in no_console rules to optimize message formatting when the allow list is empty.
- Replacing `Vec` references with slices to improve performance - Replace `to_string` with `String::new` to optimize empty string creation. - Apply formatted strings to improve readability
camc314
reviewed
Feb 25, 2025
…tring conversions.
camc314
approved these changes
Feb 25, 2025
camc314
reviewed
Feb 25, 2025
- Modify the string concatenation logic in the `no_console.rs` file to uniformly use the `join(",")` method.
- Update the corresponding snapshot tests to reflect these changes, ensuring no extra spaces are included.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no_console_diagnosticfunction to add a list of allowed methods argument