feat(linter): add support for `extends` property in oxlintrc by camchenry · Pull Request #9217 · oxc-project/oxc

camchenry · 2025-02-19T03:22:55Z

part of linter: Add support for extends keyword #9307

Allows oxlint configuration files to include an extends key at the top level. For now (until we decide to change it), this is strictly treated as a list of file paths and we don't support string values like eslint:recommended or anything like that.

camchenry · 2025-02-19T03:23:19Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-02-19T03:36:13Z

CodSpeed Performance Report

Merging #9217 will not alter performance

_{Comparing 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc (3fce826) with main (a84f6c2)}

Summary

✅ 33 untouched benchmarks

camchenry · 2025-03-01T22:59:44Z

@Boshen @Sysix @camc314 This stack is ready to be reviewed. I think merging the rest of these PRs should make nested configurations actually useful. It will allow nested configuration files to extend other config files and inherit rules, plugins, and overrides from them.

After we merge all of these, I'll try to write some documentation on the website and we should do some more thorough testing and bug fixing as well.

Sysix

Great work 👍
I added comments in some PRs but they should be all non blocking :)

camchenry · 2025-03-04T02:36:25Z

Merge activity

Mar 3, 9:36 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 3, 9:36 PM EST: A user added this pull request to the Graphite merge queue.
Mar 3, 9:41 PM EST: A user merged this pull request with the Graphite merge queue.

- part of #9307 Allows oxlint configuration files to include an `extends` key at the top level. For now (until we decide to change it), this is strictly treated as a list of file paths and we don't support string values like `eslint:recommended` or anything like that.

## [0.15.14] - 2025-03-11 ### Features - 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode) - ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric DIRAND) - 50327f3 linter: Add import/exports-last (#9578) (yefan) - 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481) (yefan) - 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode) - 41f32ea linter: Allow adding more overrides via `extends` configs (#9475) (camchenry) - fb7cf10 linter: Allowing `plugins` to be extended with `extends` (#9473) (camchenry) - fc74849 linter: Inherit `rules` via the extended config files (#9308) (camchenry) - 3fce826 linter: Add support for `extends` property in oxlintrc (#9217) (camchenry) ### Bug Fixes - 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632) (therewillbecode) - a9d7df9 linter: False positive in `unicorn/escape-case` (#9638) (shulaoda) - 3831819 linter: Fix example lint declaration and macro syntax (#9626) (Uli) - 4ca62ab linter: Output right file line and column for `.vue`, `.astro` and `.svelte` files (#9484) (Sysix) - 3105159 linter: Do not output number of rules with nested configs (#9476) (camchenry) - 5ecda01 linter: Support nested extending (#9472) (camchenry) ### Documentation - b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658) (therewillbecode) - 1cc43f7 linter: Improve the documentation of `eslint-no-console` (#9612) (therewillbecode) - 608bb77 linter: Improve the docs and add test case for `typescript-no-extra-non-null-assertion` (#9609) (therewillbecode) - 43add5d linter: Better docs for `typescript-no-non-null-asserted-nullish-coalescing` rule (#9610) (therewillbecode) - bd90ce6 linter: Improve the docs and add test cases for `eslint-no-shadow-restricted-names` (#9597) (therewillbecode) - a0c9f7c linter: Improve the documentation of `eslint-no-func-assign` (#9596) (therewillbecode) - ec922e9 linter: Improve the documentation of `typescript-consistent-type-definitions` (#9575) (therewillbecode) - 165c89d linter: Improve the documentation of `typescript-no-namespace` (#9545) (therewillbecode) ### Refactor - c174600 linter: Improve `eslint/no-duplicate-imports` (#9627) (therewillbecode) - 31ba425 linter: Improve `eslint/no-self-assign` (#9635) (therewillbecode) - 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen) - be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda) - b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda) - 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode) - 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen) ### Testing - 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry) Co-authored-by: Boshen <[email protected]>

github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Feb 19, 2025

This was referenced Feb 19, 2025

feat(oxlint): add --experimental-nested-config option #9152

Merged

feat(linter): add support for nested config files #9153

Merged

fix(linter): do not use nested configs with --config option #9155

Merged

camchenry mentioned this pull request Feb 19, 2025

test(linter): ensure CLI filters take precedence over nested configs #9156

Merged

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from f94f818 to 916be0d Compare February 19, 2025 03:27

Boshen force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from ad7f677 to 3801f11 Compare February 20, 2025 02:47

Boshen force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 916be0d to 66fd06f Compare February 20, 2025 02:48

camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 3801f11 to b29c336 Compare February 22, 2025 04:43

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 66fd06f to 000602f Compare February 22, 2025 04:43

camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from b29c336 to 28d9e68 Compare February 22, 2025 22:25

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 000602f to c44dac0 Compare February 22, 2025 22:25

github-actions bot added the A-cli Area - CLI label Feb 22, 2025

camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 18eaaf5 to 653750a Compare February 22, 2025 22:34

graphite-app bot force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 653750a to 4667457 Compare February 22, 2025 22:49

camchenry force-pushed the 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs branch from 4667457 to cbbf941 Compare February 22, 2025 23:09

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 3beb0e5 to 2571905 Compare February 22, 2025 23:09

Boshen changed the base branch from 02-15-test_linter_ensure_cli_filters_take_precedence_over_nested_configs to graphite-base/9217 February 22, 2025 23:16

Boshen force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 2571905 to 3208a6c Compare February 22, 2025 23:21

Boshen force-pushed the graphite-base/9217 branch from cbbf941 to e49c92d Compare February 22, 2025 23:21

Boshen changed the base branch from graphite-base/9217 to main February 22, 2025 23:21

Boshen force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 3208a6c to 25ac981 Compare February 22, 2025 23:21

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 25ac981 to 7f3a3de Compare February 23, 2025 19:18

camchenry mentioned this pull request Feb 23, 2025

feat(linter): inherit rules via the extended config files #9308

Merged

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 7f3a3de to c92ba6c Compare February 24, 2025 03:58

camchenry mentioned this pull request Mar 1, 2025

fix(linter): support nested extending #9472

Merged

camchenry marked this pull request as ready for review March 1, 2025 17:42

camchenry mentioned this pull request Mar 1, 2025

feat(linter): allowing plugins to be extended with extends #9473

Merged

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from c92ba6c to dfdbb48 Compare March 1, 2025 22:35

This was referenced Mar 1, 2025

feat(linter): allow adding more overrides via extends configs #9475

Merged

fix(linter): do not output number of rules with nested configs #9476

Merged

Sysix approved these changes Mar 2, 2025

View reviewed changes

camchenry mentioned this pull request Mar 3, 2025

test(linter): remove test dependency on oxlint #9513

Merged

camchenry force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from dfdbb48 to 7cab29f Compare March 3, 2025 18:12

camchenry added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025

graphite-app bot force-pushed the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch from 7cab29f to 3fce826 Compare March 4, 2025 02:37

graphite-app bot merged commit 3fce826 into main Mar 4, 2025
25 checks passed

graphite-app bot deleted the 02-18-feat_linter_add_support_for_extends_property_in_oxlintrc branch March 4, 2025 02:41

oxc-bot mentioned this pull request Mar 11, 2025

release(oxlint): v0.15.14 #9681

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

feat(linter): add support for `extends` property in oxlintrc#9217

feat(linter): add support for `extends` property in oxlintrc#9217
graphite-app[bot] merged 1 commit intomainfrom
02-18-feat_linter_add_support_for_extends_property_in_oxlintrc

camchenry commented Feb 19, 2025 •

edited

Loading

Uh oh!

camchenry commented Feb 19, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Feb 19, 2025 •

edited

Loading

Uh oh!

camchenry commented Mar 1, 2025

Uh oh!

Sysix left a comment

Uh oh!

camchenry commented Mar 4, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

camchenry commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camchenry commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

codspeed-hq bot commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #9217 will not alter performance

Summary

Uh oh!

camchenry commented Mar 1, 2025

Uh oh!

Sysix left a comment

Choose a reason for hiding this comment

Uh oh!

camchenry commented Mar 4, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camchenry commented Feb 19, 2025 •

edited

Loading

camchenry commented Feb 19, 2025 •

edited

Loading

codspeed-hq bot commented Feb 19, 2025 •

edited

Loading

camchenry commented Mar 4, 2025 •

edited by graphite-app bot

Loading