feat(ast_tools): add #[builder(default)] attribute for structs and enums#9203
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 18, 2025
Conversation
github-actions
bot
added
A-ast-tools
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9203 will not alter performanceComparing Summary
|
This was referenced Feb 18, 2025
Merged
Contributor
Merge activity
|
…enums (#9203) Add a `#[builder(default)]` attribute which can be used on structs or enums to indicate that AST builder methods should not require this field. Use that attribute on `ScopeId`, `SymbolId` and `ReferenceId`, to replace the hard-coded list of semantic ID types in codegen for `AstBuilder`. Does not affect generated code, only the mechanisms by which it's generated.
graphite-app
bot
force-pushed
the
02-18-feat_ast_tools_add_builder_default_attribute_for_structs_and_enums
branch
from
5d9ec0a to
3e7b21c
Compare
graphite-app
bot
deleted the
02-18-feat_ast_tools_add_builder_default_attribute_for_structs_and_enums
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
#[builder(default)]attribute which can be used on structs or enums to indicate that AST builder methods should not require this field.Use that attribute on
ScopeId,SymbolIdandReferenceId, to replace the hard-coded list of semantic ID types in codegen forAstBuilder.Does not affect generated code, only the mechanisms by which it's generated.