How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

CodSpeed Performance Report

Merging #8854 will improve performances by 8.67%

_{Comparing shulaoda:perf/reduce-unnecessary-rule-method-executions (e975e3a) with main (d6d13dd)}

Summary

⚡ 3 improvements
✅ 30 untouched benchmarks

Benchmarks breakdown

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ linter[RadixUIAdoptionSection.jsx] 2.6 ms 2.3 ms +9.05%
⚡ linter[cal.com.tsx] 1.2 s 1.1 s +8.09%
❌ linter[checker.ts] 2.8 s 3.5 s -20.85%

When running on my windows machine (13th Gen Intel(R) Core(TM) i5-13600KF 3.50 GHz), the performance of checker.ts significantly improved by 50%. I believe this is influenced by the configuration of each person's computer. At this point, I have not enabled the optimizations from #6600.

Introducing bitflags did not result in a performance improvement, and in fact, it caused a slight decrease of around 2%. However, it benefits memory management and provides better maintainability, so I have decided not to roll it back.

I like the overall direction, but dislike requiring

    fn should_run(&self, _: &crate::ContextHost) -> crate::rule::ShouldRunMeta {
        crate::rule::ShouldRunMeta::IS_RUN_ONCE
    }

everywhere.

By default, If use run, It shouldn’t require explicitly implementing should_run. Perhaps we can use a procedural macro to automate this? Do you have any good ideas?

Agreed with @Boshen: something like this is definitely worth doing, but maybe we can polish the experience a little bit more. My suggestion would be that maybe we can make it as part of the declare_oxc_lint! macro:

So maybe it would look more like this (without doc comments):

declare_oxc_lint!(
    SomeLintRule(IsRunOnSymbol),
    oxc,
    nursery
);

Not 100% sure how to parse it like that though, not too familiar with macros

So maybe it would look more like this (without doc comments):

declare_oxc_lint!(
    SomeLintRule(IsRunOnSymbol),
    oxc,
    nursery
);

Not 100% sure how to parse it like that though, not too familiar with macros

This doesn't seem feasible (because ( and ) cannot be parsed as a token), we can:

declare_oxc_lint!(
    SomeLintRule,
    oxc,
    nursery,
    IsRunOnSymbol,
);

or

#[derive(Debug, Default, Clone)]
#[should_run(is_run_once)]
pub struct PreferToBeObject;

Ok my decision is that the total amount of changes is not worth it for +8.67%, unless we find a better approach to get the same performance boost.