feat(minifier): compress a != null ? a : b into a ?? b#8801
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 31, 2025
Merged
feat(minifier): compress a != null ? a : b into a ?? b#8801graphite-app[bot] merged 1 commit intomainfrom
a != null ? a : b into a ?? b#8801graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
sapphi-red
force-pushed
the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
from
951a3bc to
6213d1e
Compare
sapphi-red
changed the base branch from
main
to
01-31-fix_minifier_fix_var_undefined_1_foo_null_foo_undefined_should_not_be_compressed
CodSpeed Performance ReportMerging #8801 will not alter performanceComparing Summary
|
Boshen
changed the base branch from
01-31-fix_minifier_fix_var_undefined_1_foo_null_foo_undefined_should_not_be_compressed
to
graphite-base/8801
Boshen
force-pushed
the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
from
6213d1e to
acbd198
Compare
Boshen
force-pushed
the
graphite-base/8801
branch
from
351ffaf to
2eac9c0
Compare
Boshen
force-pushed
the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
from
acbd198 to
7b1f68e
Compare
sapphi-red
force-pushed
the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
2 times, most recently
from
e4cd785 to
6f26411
Compare
Member
Merge activity
|
graphite-app
bot
force-pushed
the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
from
6f26411 to
72d74a2
Compare
graphite-app
bot
deleted the
01-31-feat_minifier_compress_a_null_a_b_into_a_b_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems this was implemented in past by #8352 and was reverted in #8411. I'm not sure what was buggy, but one difference with this PR is that the previous PR doesn't check whether the identifier is a global reference or not.