refactor(linter): remove remapping for plugin name in diagnostics#8223
Merged
Boshen merged 6 commits intooxc-project:mainfrom Jan 3, 2025
Sysix:refactor-remove-plugin-name-remapping
Merged
refactor(linter): remove remapping for plugin name in diagnostics#8223Boshen merged 6 commits intooxc-project:mainfrom Sysix:refactor-remove-plugin-name-remapping
Boshen merged 6 commits intooxc-project:mainfrom
Sysix:refactor-remove-plugin-name-remapping
Conversation
This reverts commit 992b81e.
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
CodSpeed Performance ReportMerging #8223 will not alter performanceComparing Summary
|
camc314
approved these changes
Jan 2, 2025
Boshen
added a commit
that referenced
this pull request
Jan 13, 2025
## [0.15.6] - 2025-01-13 ### Features - 457aa31 linter: Implement `no-lone-blocks` rule (#8145) (Yuichiro Yamashita) ### Refactor - aea9551 ast: Simplify `get_identifier_reference` of `TSType` and `TSTypeName` (#8273) (Dunqing) - 43ed3e1 linter: Add output formatter (#8436) (Alexander S.) - 4e05e66 linter: Remove glob for windows (#8390) (Alexander S.) - b19d809 linter: Split `unicorn/prefer-spread` and `eslint/prefer-spread` into own rules (#8329) (Alexander S.) - 3c534ae linter: Refactor `LintBuilder` to prep for nested configs (#8034) (camc314) - 2f9fab9 linter: Remove remapping for plugin name in diagnostics (#8223) (Alexander S.) ### Testing - b6c1546 linter: Use plugin name instead of category for finding rule (#8353) (Alexander S.) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
came across this code.
I do not think this is practicable in the real world. Many projects areo migrating from jest to vitest and are currently installing both,
So we can't really tell what plugin name should be outputted.
The same is for typescript <-> eslint and our newest candidate:
oxc/crates/oxc_linter/src/config/rules.rs
Lines 163 to 165 in 2da4365