feat(minifier): remove unnecessary "use strict"#8173
Closed
sapphi-red wants to merge 2 commits intomainfrom
Closed
feat(minifier): remove unnecessary "use strict"#8173sapphi-red wants to merge 2 commits intomainfrom
sapphi-red wants to merge 2 commits intomainfrom
Conversation
github-actions
bot
added
A-minifier
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 29, 2024
CodSpeed Performance ReportMerging #8173 will not alter performanceComparing Summary
|
sapphi-red
force-pushed
the
12-29-feat_minifier_remove_unnecessary_use_strict_
branch
from
39eeb7b to
fd9ef8b
Compare
sapphi-red
commented
Dec 29, 2024
Comment on lines
+131
to
+139
| /// Drop `"use strict";` directives if the function is empty. | ||
| fn drop_use_strict_directives_if_function_is_empty( | ||
| body: &mut FunctionBody<'a>, | ||
| _ctx: &mut TraverseCtx<'a>, | ||
| ) { | ||
| if body.statements.is_empty() { | ||
| body.directives.retain(|directive| !directive.is_use_strict()); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
I'm not sure if it makes sense to exist in PeepholeRemoveDeadCode. This has to run after everything that might remove statements.
Boshen
changed the base branch from
12-29-feat_minifier_fold_string.length___array.length_
to
graphite-base/8173
Boshen
force-pushed
the
graphite-base/8173
branch
from
f5a4570 to
fc43ec5
Compare
Boshen
force-pushed
the
12-29-feat_minifier_remove_unnecessary_use_strict_
branch
from
fd9ef8b to
81378e3
Compare
…o PeepholeRemoveDeadCode
Boshen
force-pushed
the
12-29-feat_minifier_remove_unnecessary_use_strict_
branch
from
81378e3 to
ff48152
Compare
Member
|
This is not ideal, I'll try something else later. |
Boshen
deleted the
12-29-feat_minifier_remove_unnecessary_use_strict_
branch
Member
Author
|
@Boshen Did you try this one? |
Member
nope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.