feat(linter): implement no-labels rule#8131
Merged
camc314 merged 2 commits intooxc-project:mainfrom Dec 27, 2024
Merged
Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
github-actions
bot
added
A-linter
Contributor
Author
|
(Noob question) I saw that the CI status is stuck at "waiting for approval". Wanna ask do I need to anything special?
|
Contributor
|
Running now. apologies, didn't notice the first time |
CodSpeed Performance ReportMerging #8131 will not alter performanceComparing Summary
|
Boshen
added a commit
that referenced
this pull request
Dec 30, 2024
## [0.15.4] - 2024-12-30 ### Features - 47cea9a linter: Implement `eslint/no-extra-label` (#8181) (Anson Heung) - ef76e28 linter: Implement `eslint/no-multi-assign` (#8158) (Anson Heung) - 384858b linter: Implement `jsx-a11y/no-noninteractive-tabindex` (#8167) (Tyler Earls) - afc21a6 linter: Implement `eslint/vars-on-top` (#8157) (Yuichiro Yamashita) - 65796c4 linter: Implement `eslint/prefer-rest-params` (#8155) (Yuichiro Yamashita) - 5234d96 linter: Implement `eslint/no-nested-ternary` (#8150) (Yuichiro Yamashita) - 1c5db72 linter: Implement eslint/no-labels (#8131) (Anson Heung) - 0b04288 linter: Move `import/named` to nursery (#8068) (Boshen) ### Bug Fixes - 0794bee editor/vscode: Set minimum supported ver. to `^1.93.0` (#8182) (Pavel Smirnov) - f3050d4 linter: Exclude svelte files from `no_unused_vars` rule (#8170) (Yuichiro Yamashita) - faf7464 linter: Disable rule `react/rules-of-hook` by file extension (#8168) (Alexander S.) - 1171e00 linter: Disable `react/rules-of-hooks` for vue and svelte files (#8165) (Alexander S.) - 1b9a5ba linter: False positiver in private member expr in oxc/const-comparison (#8164) (camc314) - 6bd9ddb linter: False positive in `typescript/ban-tslint-comment` (#8094) (dalaoshu) - 10a1fd5 linter: Rule: `no-restricted-imports` support option `patterns` with `group` key (#8050) (Alexander S.) - b3f38ae linter: Rule `no-restricted-imports`: support option `allowImportNames` (#8002) (Alexander S.) - 340cc90 linter: Rule `no-restricted-imports`: fix option "importNames" (#7943) (Alexander S.) - ec2128e linter: Fix line calculation for `eslint/max-lines` in diagnostics (#7962) (Dmitry Zakharov) - 79af100 semantic: Reference flags not correctly resolved when after an export stmt (#8134) (camc314) ### Performance - d8d2ec6 linter: Run rules which require typescript syntax only when source type is actually typescript (#8166) (Alexander S.) - 2736657 semantic: Allocate `UnresolvedReferences` in allocator (#8046) (Boshen) ### Refactor - de8246b language_server: Move structs into own file (#8026) (Alexander S.) - 774babb linter: Read `exported_bindings_from_star_export` lazily (#8062) (Boshen) - 547c102 linter: Use `RwLock<FxHashMap>` instead of `FxDashMap` for module record data (#8061) (Boshen) - 952d7e4 linter: Rename `flat.rs` to `config.rs` (#8033) (camc314) - 50848ed linter: Simplify `ConfigStore` to prep for nested configs (#8032) (camc314) - b2a4a78 linter: Remove unused `with_rules` and `set_rule` methods (#8029) (camc314) - 6da0b21 oxlint: Remove unused `git.rs` (#7990) (Boshen) - 58e7777 oxlint: Remove extra if check in `Walkdir` (#7989) (Boshen) - 02f968d semantic: Change `Bindings` to a plain `FxHashMap` (#8019) (Boshen) Co-authored-by: Boshen <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements eslint/no-labels rule.
Part of #479
This is my first time contributing to the oxc codebase, so appreciate any comments 🙇